From owner-freebsd-usb@FreeBSD.ORG  Thu Oct 31 01:00:02 2013
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 9BE677D5
 for <freebsd-usb@smarthost.ysv.freebsd.org>;
 Thu, 31 Oct 2013 01:00:02 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 89F3F214D
 for <freebsd-usb@smarthost.ysv.freebsd.org>;
 Thu, 31 Oct 2013 01:00:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9V102WO068143
 for <freebsd-usb@freefall.freebsd.org>; Thu, 31 Oct 2013 01:00:02 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9V102Bw068142;
 Thu, 31 Oct 2013 01:00:02 GMT (envelope-from gnats)
Date: Thu, 31 Oct 2013 01:00:02 GMT
Message-Id: <201310310100.r9V102Bw068142@freefall.freebsd.org>
To: freebsd-usb@FreeBSD.org
Cc: 
From: Adrian Chadd <adrian@freebsd.org>
Subject: Re: usb/183505: [usb] Arduino Leonardo exposes three interface
 descriptors but no modem is attached to the first one (bInterfaceSubClass=2)
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Adrian Chadd <adrian@freebsd.org>
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Oct 2013 01:00:02 -0000

The following reply was made to PR usb/183505; it has been noted by GNATS.

From: Adrian Chadd <adrian@freebsd.org>
To: Mike Meyer <mwm@mired.org>
Cc: "bug-followup@freebsd.org" <bug-followup@freebsd.org>
Subject: Re: usb/183505: [usb] Arduino Leonardo exposes three interface
 descriptors but no modem is attached to the first one (bInterfaceSubClass=2)
Date: Wed, 30 Oct 2013 17:59:49 -0700

 Gah, browser stupidity.
 
 Here's the real one:
 
 adrian@lucy-11i386:~/work/freebsd/head/src % svn diff sys/dev/usb
 Index: sys/dev/usb/serial/umodem.c
 ===================================================================
 --- sys/dev/usb/serial/umodem.c (revision 257371)
 +++ sys/dev/usb/serial/umodem.c (working copy)
 @@ -128,6 +128,9 @@
         {USB_IFACE_CLASS(UICLASS_CDC),
                 USB_IFACE_SUBCLASS(UISUBCLASS_ABSTRACT_CONTROL_MODEL),
                 USB_IFACE_PROTOCOL(UIPROTO_CDC_AT)},
 +       {USB_IFACE_CLASS(UICLASS_CDC),
 +               USB_IFACE_SUBCLASS(UISUBCLASS_ABSTRACT_CONTROL_MODEL),
 +               USB_IFACE_PROTOCOL(UIPROTO_CDC_NONE)},
         /* Huawei Modem class match */
         {USB_IFACE_CLASS(UICLASS_CDC),
                 USB_IFACE_SUBCLASS(UISUBCLASS_ABSTRACT_CONTROL_MODEL),
 Index: sys/dev/usb/usb.h
 ===================================================================
 --- sys/dev/usb/usb.h   (revision 257371)
 +++ sys/dev/usb/usb.h   (working copy)
 @@ -441,6 +441,7 @@
  #define        UISUBCLASS_ETHERNET_EMULATION_MODEL 12
  #define        UISUBCLASS_NETWORK_CONTROL_MODEL 13
 
 +#define        UIPROTO_CDC_NONE                0
  #define        UIPROTO_CDC_AT                  1
 
  #define        UICLASS_HID             0x03
 
 The USB 1.1 specification states that CDC=0 is just "no command
 structure over the line", versus CDC=1 which says "AT commands".
 
 This is enough to make the Leonardo work fine.
 
 Thanks to everyone else who fixed the USB protocol mis-behvaiour!
 
 
 
 -adrian