From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Dec 13 21:50:18 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44C7B16A41F for ; Tue, 13 Dec 2005 21:50:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA71743D94 for ; Tue, 13 Dec 2005 21:50:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id jBDLo6A9009659 for ; Tue, 13 Dec 2005 21:50:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id jBDLo6EV009658; Tue, 13 Dec 2005 21:50:06 GMT (envelope-from gnats) Date: Tue, 13 Dec 2005 21:50:06 GMT Message-Id: <200512132150.jBDLo6EV009658@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: "Thomas E. Zander" Cc: Subject: Re: ports/89906: multimedia/mplayer gtk2 patch X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Thomas E. Zander" List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2005 21:50:18 -0000 The following reply was made to PR ports/89906; it has been noted by GNATS. From: "Thomas E. Zander" To: bug-followup@FreeBSD.org Cc: bh@izb.knu.ac.kr Subject: Re: ports/89906: multimedia/mplayer gtk2 patch Date: Tue, 13 Dec 2005 22:41:01 +0100 Hi, a quick look at the patch looks promising. However I think it would be better to place this diff in ${FILESDIR} and apply it in the post-patch: target if WITH_GTK2 is defined. It turned out to be difficult to make successful port fetching dependent on the availability of a private homepage. I also suggest that we make gtk2 the default gui only if the mplayer dev team releases the next version with official gtk2 support. Otherwise it might be broken again and we have to move back to gtk1 until another patch is finished. I really like to keep the default installation close to the genuine config. Riggs -- - Now the world has gone to bed | Now I lay me down to sleep - -- Darkness won't engulf my head | Try to count electric sheep -- --- I can see by infra-red | Sweet dream wishes you can keep --- ---- How I hate the night | How I hate the night ----