Date: Mon, 11 Feb 2002 17:53:54 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: John Baldwin <jhb@FreeBSD.org> Cc: current@freebsd.org, bde@freebsd.org Subject: RE: ucred holding patch, BDE version Message-ID: <Pine.BSF.4.21.0202111752210.18316-100000@InterJet.elischer.org> In-Reply-To: <XFMail.020211203054.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 11 Feb 2002, John Baldwin wrote: > > On 11-Feb-02 Julian Elischer wrote: > > here is the BDE version ready to commit. > > Extended to other architectures. > > > > Bruce, John, comments? > > > > As I was adding a prototype to ucred.h I stripped the __Ps of the others in > > that > > section > > (in the spirit of "change it when editing it anyhow" > > Hmm, acquire_ucred (don't really like that name, maybe thread_updatecred(td) > which can use td_proc to get the proc) probably should be declared in > sys/proc.h. Well, maybe not, sys/ucred.h is probably fine. But it's > implementation should then be in kern_prot.c along with all the other ucred > related functions. :) I guess so. The name requires changing anyhow as it was pointed out to me that Bruce mis-spelled acquire and I didn't notice. > > Also, please make the comment above the function into a complete sentence and > capitalize appropriately, etc. as per style(9) just to be pedantic. I guess > removing __P() as you go is ok if that spirit is what the -arch thread is > desired. Personally I thought it should be the other way around just like we > don't mix whitespace commits with code commits to avoid obfuscating function > changes with style changes. IMO, just commit to ucred.h blowing away __P() > first, then commit your functional changes with the rest. hmmm I am completely confused as to which way we ended up deciding then.. :-) > > -- > > John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0202111752210.18316-100000>