From owner-svn-src-head@freebsd.org Thu Jun 14 03:32:56 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 27DB61019985 for ; Thu, 14 Jun 2018 03:32:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22b.google.com (mail-it0-x22b.google.com [IPv6:2607:f8b0:4001:c0b::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A80336F241 for ; Thu, 14 Jun 2018 03:32:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22b.google.com with SMTP id p185-v6so6809196itp.4 for ; Wed, 13 Jun 2018 20:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=HofdsxjKybOQCVIRoN6BWchnCIdfNTXrHon3gBxaaBw=; b=eSJuvXW44y+JX6SBXB/xcfnFv0U03LLEBuzoDHixTHMn9UEg3o7gr9AfHBLsSY2KAL ri/SEC02LplPsD4Mdu2KzwT3j6vRY4K2i9d/CmcGzxVyGboKeJtuEjxqPXSBxN2/ssm8 QA84+9Y2no0CNM6nJB5ySn8dKnBDcbTC6WYau+SYgG7Q19ggEQZrMUW7Vo7b2Jx5HDh9 +3XoxGtt5rJG6fmTNXzp0bmebC3s4BlP2cXSVq3qs9gsR/K4xufbcc3Sen36RsYJWofS d7ZQ5Z/v19cMv4+dpyZxyp7zFDtfaLrfnu4Y6keDG51aVVHixBL/iMxEYyi9sx7rxwMa v/QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=HofdsxjKybOQCVIRoN6BWchnCIdfNTXrHon3gBxaaBw=; b=fa+8CH/GEhsWM8n85+vxpP8Uk2bAtpN8PkBvpO8dFMRCRJHH7ioXAekQ5Q39nY+FNO mVInZzE5LXfGpJSD8W+x0qh5MFa3J6jnOdm8GzbI0yL4evVmSH6Y60KZXQ/KWULOWddS kToN8187AobVlEWZgzxJ+fHwy2wGEaOcPTKW3Sk9t2QKf49mErU65IlLhy/8nTF92Vn5 2ewzeMxEpjvUgs/A8ZOM5s491GdloE/xOe7ekEuGuHddWtACP5f2dvT9yzFHbEt/Ujay CoTkFmlnrEofr+SDp2dsahsGuHMC7p2rT0FutSUQ2jFwelq0m24Qoc670O7XWWW4QOQR FV3w== X-Gm-Message-State: APt69E2x6OV+fEWq2C4e4x4MzZaiqWEEIZ8fT1Dl1ctNoosfsCXDacaD 5eqEyLrjC3plCC/t/jgO7le1UQjM1ipEOGWljreX8w== X-Google-Smtp-Source: ADUXVKLu3BNxKg4QopV6g/vRxGHd5RGJ67hKxP4khqHC59ZjnktwtkgZcBwcJjf/apE0/s+6kNuzGfR2M3s1bhRUN0s= X-Received: by 2002:a02:9aba:: with SMTP id m55-v6mr305796jak.140.1528947175048; Wed, 13 Jun 2018 20:32:55 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:d028:0:0:0:0:0 with HTTP; Wed, 13 Jun 2018 20:32:54 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201806140328.w5E3SCZp042620@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Wed, 13 Jun 2018 21:32:54 -0600 X-Google-Sender-Auth: x8jxzwf8KEPxT62DfPnKN4QC54k Message-ID: Subject: Re: svn commit: r335091 - head/sbin/nvmecontrol To: "Rodney W. Grimes" Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 03:32:56 -0000 Actually, that file (nvmecontrol_ext.h) is completely new. I'm not sure why it thought I copied it from util.c. Maybe it's a git svn integration thing. Warner On Wed, Jun 13, 2018 at 9:31 PM, Warner Losh wrote: > Ah, that's what you were talking about. OK. Will do. > > Warner > > On Wed, Jun 13, 2018 at 9:28 PM, Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > >> > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < >> > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >> > >> > > > Author: imp >> > > > Date: Wed Jun 13 22:00:02 2018 >> > > > New Revision: 335091 >> > > > URL: https://svnweb.freebsd.org/changeset/base/335091 >> > > > >> > > > Log: >> > > > Make it possible to use print_controller from another program >> > > > >> > > > Rename print_controller to nvme_print_controller. Put it in its >> > > > own file for easy inclusion. Move util.c to be nc_util.c to not >> > > > conflict with camcontrol. add nvecontrol_ext.h to define shared >> > > > interfaces. >> > > > >> > > > Sponsored by: Netflix >> > > > Differential Revision: https://reviews.freebsd.org/D15371 >> > > > >> > > > Added: >> > > > head/sbin/nvmecontrol/identify_ext.c >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/identify >> .c >> > > > head/sbin/nvmecontrol/nc_util.c >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c >> > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props >> changed) >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c >> > > ... >> > > >> > > > >> > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from >> > > r335089, head/sbin/nvmecontrol/util.c) >> > > > ============================================================ >> > > ================== >> > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 >> > > (r335089, copy source) >> > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 >> 2018 >> > > (r335091) >> > > > @@ -1,7 +1,8 @@ >> > > > /*- >> > > > - * Copyright (c) 2017 Netflix, Inc >> > > > - * All rights reserved. >> > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD >> > > > * >> > > > + * Copyright (C) 2018 Netflix >> > > >> > > You moved a copyright forward, that is not proper to do. >> > > >> > >> > Thought it was. I honestly don't care where (nor does my employer), so >> if >> > you want to tweak it to be more conforming, be my guest. >> >> You can add a new date to the end of a list, but you should always >> retain the oldest date, and many opinions are that all dates should >> be retained unless they are continuous. >> >> It would be much simpler for you to commit: >> - * Copyright (C) 2018 Netflix >> + * Copyright (C) 2017-2018 Netflix >> >> Than for me to get approval: bde, phk. >> >> Thanks. >> Rod >> >> > >> > > Not sure about dropping the , Inc either. >> > >> > >> > Doesn't matter. Different Netflix committers do different things and I >> was >> > trying to move towards uniformity. >> >> Ok >> >> > Warner >> >> -- >> Rod Grimes >> rgrimes@freebsd.org >> > >