From nobody Sat Aug 23 07:38:58 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c887t6Ff8z65V0j; Sat, 23 Aug 2025 07:39:06 +0000 (UTC) (envelope-from aokblast@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c887t5T0Qz3S2G; Sat, 23 Aug 2025 07:39:06 +0000 (UTC) (envelope-from aokblast@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755934746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pbd3xFRq/pXKnHwK5bwkNT+KDLf+6mMogtuUXd4OH8A=; b=hrdt+Dbpm/wdSjUfABGGAnqVOLZvFAZZc0Iw2MQVMKOHjvlGisSz5B2aKMGmiD/y1xctMZ rg4UWRG45n6TNVe7uD6+W1xhgWa7KWVFkzNSj84uXsCGYU3IFBShHlyAHOnMGD7BFYSS6Z f8ERHnyFW4xqXX/ChseGP8oapl1tPfOyUYWkuXZmX4zxZ+6IoUcO0tKV1k3WhAkP7R2G1I RAf+PQ3nnfapZTMKzPnMuW7NHy6sOX+s4lsddP471fGr2++GU5h6PSrI/R8wBiufaHhXgw KqBi2OEE9S7iuKuINCh4ZygM66QLJXjdrUdaxAT9l2YeSi7/U8Ce0wwwIMg73A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755934746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pbd3xFRq/pXKnHwK5bwkNT+KDLf+6mMogtuUXd4OH8A=; b=BDZJ9fq5qmouhHUlLVValw3stjhjtCqtRk4y0Er5UuiblZ8Crl7MOomM3uyMtozA19x/ll z+IyFkOBJSyHqIv0qzFAYv1XwHbnX2Dc9PUMhH8IoMczTphBYvrVq9P1ibT7IOWH4BvQap 0W9KcEfJQCIkBCGLEeHEySueGtZVGHFjI+Jg5t5hEQU85a/il01hhwTPrLOdBF52TW6HEw epm8cnuAw3+JdP6y4Bwejr38uYCkHbBtsPoP+pqH707XuMKRhAGiBfgkzynxdYEQq1IGzE ln9paQMrrZhNr0qQebE++9XpWfeaaZwd8IXD4tI1I1vSZjwmVQ7Sivqf3DTwXQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755934746; a=rsa-sha256; cv=none; b=rxheeSHzUZpzwkuv3kNzAjI/9Ae+iPnbibA7Mr2wgzScaIVUQvlQiA5SaJlDZhiSAWejKN OEc0ZOQhiFs4cjVYrdfSetsClf98+UxsY7bCAMQKdBAQfBcEOEcQgE8u+fCqR+vCERDWXn Z2G0aw6qmBxFyhHSvxRv+b6iybh+/j7NryQ3qm2c1c42QGlrIGNUb4pCfzght6Ag7QmgRM TzDd7+F0Xr7ObriS1K3YVR6FsRzetwPRVEJKvRjsQvTrCV+Fk3QlDcOfh5KsUYelHEdmII YDiN6qIioz5jxjsWBFN3+fKFAm7pMJL75p31VrZnApzCLeZLIJJY7phcO931bA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from aokblastdeMacBook-Pro.local (2001-b011-3808-3444-8815-4b72-35c6-0ccc.dynamic-ip6.hinet.net [IPv6:2001:b011:3808:3444:8815:4b72:35c6:ccc]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: aokblast) by smtp.freebsd.org (Postfix) with ESMTPSA id 4c887r6JyNz1Dd; Sat, 23 Aug 2025 07:39:04 +0000 (UTC) (envelope-from aokblast@freebsd.org) From: ShengYi Hung To: Gordon Bergling Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1685192ea1fa - main - hkbd: remove erorr detection in KDSKBSTATE ioctl In-Reply-To: (Gordon Bergling's message of "Sat, 23 Aug 2025 08:59:07 +0200") References: <202508230450.57N4oxwG023161@gitrepo.freebsd.org> User-Agent: mu4e 1.12.12; emacs 30.1 Date: Sat, 23 Aug 2025 15:38:58 +0800 Message-ID: List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain Hello, thanks for the reminder. I compile the standalone module to test so didn't discover that. Fix it right now. Gordon Bergling writes: > Hi ShengYi, > > On Sat, Aug 23, 2025 at 04:50:59AM +0000, ShengYi Hung wrote: >> The branch main has been updated by aokblast: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=1685192ea1faac28f2d4feede53e70b6a380500f >> >> commit 1685192ea1faac28f2d4feede53e70b6a380500f >> Author: ShengYi Hung >> AuthorDate: 2025-08-21 17:59:15 +0000 >> Commit: ShengYi Hung >> CommitDate: 2025-08-23 04:50:09 +0000 >> >> hkbd: remove erorr detection in KDSKBSTATE ioctl >> >> The KDSKBSTATE ioctl brings the LED up. However, some keyboards (like qemu >> keyboard) may not have LED or failed to set the LED due to unexpected reason. >> Therefore, removing the error check as ukbd(4) does allow the keyboard works >> correctly with kbdcontrol(4). >> >> Also move hw.hid.hkbd.no_leds sysctl out of HID_BUG thus users can >> disable setting LEDs >> >> PR: 288968 >> Reviewed by: wulf >> Tested by: trashcan@ellael.org, marklmi26-fbsd@yahoo.com, trkellers@gmail.coom >> Approved by: lwsu (mentor), markj (mentor) >> MFC after 1 week >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews.freebsd.org/D52101 >> >> mvalsmva >> --- > > I am not sure how this is related, but since that commit, buildkernel of GENERIC is broken both > on amd64 and aarch64. The following error is from an amd64 build, aarch64 is the same. > > ----------------------------- > /storage/freebsd/src/current/sys/dev/hid/hkbd.c:1831:10: error: called object type 'char[5]' is not a function or function pointer > 1831 | DPRINTF(("error %d", error)); > | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ > /storage/freebsd/src/current/sys/dev/hid/hid.h:212:34: note: expanded from macro 'DPRINTF' > 212 | #define DPRINTF(...) DPRINTFN(1, __VA_ARGS__) > | ~~~~~~~~~~~~^~~~~~~~~~~~ > /storage/freebsd/src/current/sys/dev/hid/hid.h:208:17: note: expanded from macro 'DPRINTFN' > 208 | printf("%s: " fmt, \ > | ~~~~~~ ^ > 1 error generated. > --- hkbd.o --- > *** [hkbd.o] Error code 1 > ----------------------------- > > --Gordon -- Best Regards. ShengYi Hung.