Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 May 2021 12:28:58 +0000
From:      bugzilla-noreply@freebsd.org
To:        ipfw@FreeBSD.org
Subject:   [Bug 255775] panic with ipfw turned on at boot time
Message-ID:  <bug-255775-8303-QLuT9Kixbv@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-255775-8303@https.bugs.freebsd.org/bugzilla/>
References:  <bug-255775-8303@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255775

--- Comment #10 from Michael Meiszl <michael@meiszl.de> ---
Just a note, in the file you have pointed out to patch, just a few lines be=
low
on 834 you find
   error =3D ip_fragment(ip, &m, mtu, ifp->if_hwassist);
        if (error)
                goto bad;
        for (; m; m =3D m0) {
                m0 =3D m->m_nextpkt;
                m->m_nextpkt =3D 0; <<<<<<<!!!!
                if (error =3D=3D 0) {
                        /* Record statistics for this interface address. */
                        if (ia !=3D NULL) {
                                counter_u64_add(ia->ia_ifa.ifa_opackets, 1);
                                counter_u64_add(ia->ia_ifa.ifa_obytes,
                                    m->m_pkthdr.len);
                        }

although legal "m->m_nextpkt =3D 0;" does not look right. Better it should =
be
"m->m_nextpkt =3D NULL;" I think.

but 0 is surely not 0xdeadc0de...

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255775-8303-QLuT9Kixbv>