From owner-svn-ports-all@FreeBSD.ORG Tue Dec 11 15:58:53 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D78D8BE; Tue, 11 Dec 2012 15:58:53 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (unknown [IPv6:2a03:6f00:1::5c35:743c]) by mx1.freebsd.org (Postfix) with ESMTP id 262CE8FC08; Tue, 11 Dec 2012 15:58:53 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:DHE-RSA-CAMELLIA256-SHA:256) (Exim 4.80) (envelope-from ) id 1TiSEN-0007xp-9b; Tue, 11 Dec 2012 19:58:51 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id BFDE1B84D; Tue, 11 Dec 2012 19:58:50 +0400 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id B714C643; Tue, 11 Dec 2012 19:58:50 +0400 (MSK) Date: Tue, 11 Dec 2012 19:58:50 +0400 From: Dmitry Marakasov To: Baptiste Daroussin Subject: Re: svn commit: r308655 - in head/games/xmoto: . files Message-ID: <20121211155850.GA27873@hades.panopticon> References: <201212110314.qBB3EErH082058@svn.freebsd.org> <20121211033625.GA39028@FreeBSD.org> <20121211132128.GA50148@hades.panopticon> <20121211132840.GD58883@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20121211132840.GD58883@ithaqua.etoilebsd.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2012 15:58:53 -0000 * Baptiste Daroussin (bapt@FreeBSD.org) wrote: > > > Looks like these two should also be mentioned in OPTIONS_DEFINE. > > > > Not adding them to OPTIONS_DEFINE preserves previous behaviour and I > > don't think NLS and DOCS should be in the OPTIONS_DEFINE ever - they are > > only meaningful to be set globally, and having them in individual ports > > makes large builds much more painful, as a user has to set them for tons > > of ports (even more painful without portmaster or knowing of > > config-recursive). > > My opinion on this is if you have already an OPTIONS_DEFINE it means that the > dialog(1) will be shown anyway so it doesn't hurt to add NLS and DOCS to it. > > if you do not have OPTIONS_DEFINE for something else then yes I can understand > you don't want to bother users with dialog coming up all the time. The said is true, but so it is inconsistent. What if there's single `true' option in addition to DOCS/NLS and it's removed? Removing NLS and DOCS this way has no real reason and is POLA violation wrt users who use them. Leaving them, otoh, is a pain for users which never built this port. I'd prefer some additional infrastructure to deal with it. The following solution seem really convenient for me: Introduce user-set list of options which are handled a bit differently: when the port is build for the first time, and for config-recursive (afaik, both are handled in config-conditional target), the dialog is not brought up if ALL of options are in that list. They are still shown in plain `make config'. That way a user who doesn't care of NLS and DOCS should just set e.g.: OPTIONS_IGNORE= NLS DOCS -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru