From nobody Thu May 11 23:32:52 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QHSqp3lVNz4BBYM for ; Thu, 11 May 2023 23:32:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QHSqp0S1Rz3N2l for ; Thu, 11 May 2023 23:32:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683847974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPW3PUE6qO6oDXgmujHhIAcVlWKo1oCNxDYK74eOXlg=; b=La5i5czKpkK9ghkwMGTi+/L6bmqWRR0Mnt2swINfkx43mFvSQA4lyfkPMrcEYLRXhAJPha McVpLgUrnOQiRk95DaCGclvsApONl5ntXo/QAnsaZwO4Ys0BAonVEnRc/5SG6JGgiBd853 2OosUfSdaHTRCg7Up/WDTHrwt/oeMXKEze5VkTU6tyodJh4E1Ir0FcBOzzz4QMDUHMtS7/ 5kvdBX2w0qo8atmjUFMGA/V3B7zW2yUk9dpADCAjXD91IqIh1sp9UZkUptqKGk9qhn8j2w JLYBLULY8HppolZzDT4voNOn+PoscYPRC2Gbsq+wVFxn9XW/F4ogDrY99RJqrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683847974; a=rsa-sha256; cv=none; b=OrOsK0mMtimbmAfCv6DsDBcUjT5aATzbjpbrxIEESv1Y+KFN75jGPOoqgYBrI4AbpLilqk wzYp1NZyYxafLCegRKVN7/PCt9OHq8NCw/hl48PT+Bl1UYb1y4I83xuuF8o/adpW79Op0a 0amg+Mlzue3WgV1zsHdyhj4lVEUWYQ95Y6VOzN2fIp2IvGOr3kTC/h0oPejhNHK2yVwHZH H7QuCy5psL4dmi5RQfSJYiCkbi54ZNyi9jYoPvmcFkBu+70FIBYXIirryR/w52Zrrdgntl sv1nZFiAdHDtODBI4he4mKcIZYrRdPzPbiXMhuIt+3KiqMvjPUjU/RwLx8R3lA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QHSqn6fYGz1Bmc for ; Thu, 11 May 2023 23:32:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34BNWrv7053678 for ; Thu, 11 May 2023 23:32:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34BNWrY6053677 for net@FreeBSD.org; Thu, 11 May 2023 23:32:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 254596] if_bridge wants LRO turned off, if_vlan insists it remain on Date: Thu, 11 May 2023 23:32:52 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: naman@freebsdfoundation.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254596 Naman Sood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |naman@freebsdfoundation.org --- Comment #7 from Naman Sood --- For what it's worth, I was able to test the patch and observe that LRO is disabled when adding a VLAN subinterface to a bridge, and re-enabled when removing it. Unfortunately, as the PRs Ed linked above show, the e1000 driv= er (what I have in my machine) doesn't actually support LRO even though it cla= ims to, so I can't test that it meaningfully changes performance. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=