Date: Fri, 08 Dec 2017 13:50:42 -0600 From: shurd@sasktel.net To: Stephen Hurd <shurd@freebsd.org>, Ryan Stone <rysto32@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r326702 - head/sys/net Message-ID: <20171208135042.aiyw0cs744044wss@webmail.sasktel.net> In-Reply-To: <CAFMmRNz1HFyxxoj4Mapdoa9puVjm21hGjOiKGB-0V3V2WpWOsw@mail.gmail.com> References: <201712081843.vB8IhVdA064251@repo.freebsd.org> <CAFMmRNz1HFyxxoj4Mapdoa9puVjm21hGjOiKGB-0V3V2WpWOsw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 8 Dec 2017 13:57:13 -0500, Ryan Stone wrote:
On Fri, Dec 8, 2017 at 1:43 PM, Stephen Hurd wrote:
> Author: shurd
> Date: Fri Dec 8 18:43:31 2017
> New Revision: 326702
> URL: https://svnweb.freebsd.org/changeset/base/326702
> + if (!M_WRITABLE(*m_head)) {
> + new_head = m_dup(*m_head, M_NOWAIT);
> + if (new_head == NULL) {
> + device_printf(dev, "cannot pad short frame, m_dup() failed");
> + return ENOMEM;
Don't we leak *m_head here? As far as I can tell the caller doesn't
deal with it.
Thanks for catching that, fixed in r326706.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171208135042.aiyw0cs744044wss>