From owner-freebsd-net@FreeBSD.ORG  Fri Mar  1 15:55:27 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx2.freebsd.org (mx2.FreeBSD.org [8.8.178.116])
 by hub.freebsd.org (Postfix) with ESMTP id 6FA927E5;
 Fri,  1 Mar 2013 15:55:27 +0000 (UTC) (envelope-from ae@FreeBSD.org)
Received: from butcher-nb.yandex.net (hub.freebsd.org
 [IPv6:2001:1900:2254:206c::16:88])
 by mx2.freebsd.org (Postfix) with ESMTP id B6C4A2977;
 Fri,  1 Mar 2013 15:55:26 +0000 (UTC)
Message-ID: <5130CF14.4090606@FreeBSD.org>
Date: Fri, 01 Mar 2013 19:53:56 +0400
From: "Andrey V. Elsukov" <ae@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Ed Maste <emaste@freebsd.org>
Subject: Re: [PATCH] Handle PACKET_TAG_IPFORWARD and TIMEWAIT state
References: <20130228191035.GA36576@sandvine.com>
 <CAPyFy2B+nX+-0JdVNazs7k=p30HuNWUjeEyRppPj-p8REtdf=A@mail.gmail.com>
In-Reply-To: <CAPyFy2B+nX+-0JdVNazs7k=p30HuNWUjeEyRppPj-p8REtdf=A@mail.gmail.com>
X-Enigmail-Version: 1.4.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Mar 2013 15:55:27 -0000

On 01.03.2013 01:06, Ed Maste wrote:
> On 28 February 2013 14:10, Ed Maste <emaste@freebsd.org> wrote:
>> The attached patch keeps the fwd_tag
>> around until finished with pcb lookup.
> 
> There's a small bug in that patch - a corrected version, which handles
> a NULL return from m_tag_find, can be found at:
> http://people.freebsd.org/~emaste/patches/fwd_tag_findpcb.diff

Hi Ed,

it seems this problem was there before my breakage.
Also, it think that m_tag_unlink is redundant here, because you clear
the M_IP_NEXTHOP/M_IP6_NEXTHOP flag.

-- 
WBR, Andrey V. Elsukov