From owner-svn-src-user@FreeBSD.ORG Tue May 26 22:34:13 2009 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C677106567B; Tue, 26 May 2009 22:34:13 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 4AE9A8FC0A; Tue, 26 May 2009 22:34:13 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n4QMYDo0075958; Tue, 26 May 2009 22:34:13 GMT (envelope-from kmacy@svn.freebsd.org) Received: (from kmacy@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n4QMYDGR075957; Tue, 26 May 2009 22:34:13 GMT (envelope-from kmacy@svn.freebsd.org) Message-Id: <200905262234.n4QMYDGR075957@svn.freebsd.org> From: Kip Macy Date: Tue, 26 May 2009 22:34:13 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r192863 - user/kmacy/releng_7_2_fcs/sys/vm X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2009 22:34:13 -0000 Author: kmacy Date: Tue May 26 22:34:13 2009 New Revision: 192863 URL: http://svn.freebsd.org/changeset/base/192863 Log: - drop the more heavily contended queue mutex first - assert that the page lock is not held at the end of the loop when maxlaunder > 0 - drop the page lock before moving to the next page if none of the condition are met Modified: user/kmacy/releng_7_2_fcs/sys/vm/vm_pageout.c Modified: user/kmacy/releng_7_2_fcs/sys/vm/vm_pageout.c ============================================================================== --- user/kmacy/releng_7_2_fcs/sys/vm/vm_pageout.c Tue May 26 22:33:10 2009 (r192862) +++ user/kmacy/releng_7_2_fcs/sys/vm/vm_pageout.c Tue May 26 22:34:13 2009 (r192863) @@ -961,8 +961,8 @@ rescan0: * of time. */ if (object->type == OBJT_VNODE) { - vm_page_unlock(m); vm_page_unlock_queues(); + vm_page_unlock(m); vp = object->handle; if (vp->v_type == VREG && vn_start_write(vp, &mp, V_NOWAIT) != 0) { @@ -1059,8 +1059,10 @@ unlock_and_continue: next = TAILQ_NEXT(&marker, pageq); TAILQ_REMOVE(&vm_page_queues[PQ_INACTIVE].pl, &marker, pageq); + vm_page_lock_assert(m, MA_NOTOWNED); continue; } + vm_page_unlock(m); VM_OBJECT_UNLOCK(object); }