From owner-p4-projects@FreeBSD.ORG  Fri Jul 13 14:10:35 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A667916A408; Fri, 13 Jul 2007 14:10:34 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 602D916A403;
	Fri, 13 Jul 2007 14:10:34 +0000 (UTC)
	(envelope-from lulf@FreeBSD.org)
Received: from fri.itea.ntnu.no (fri.itea.ntnu.no [129.241.7.60])
	by mx1.freebsd.org (Postfix) with ESMTP id 209B613C49D;
	Fri, 13 Jul 2007 14:10:34 +0000 (UTC)
	(envelope-from lulf@FreeBSD.org)
Received: from localhost (localhost [127.0.0.1])
	by fri.itea.ntnu.no (Postfix) with ESMTP id E1954C335;
	Fri, 13 Jul 2007 16:08:35 +0200 (CEST)
Received: from gaupe.stud.ntnu.no (gaupe.stud.ntnu.no [129.241.56.184])
	by fri.itea.ntnu.no (Postfix) with ESMTP;
	Fri, 13 Jul 2007 16:08:35 +0200 (CEST)
Received: by gaupe.stud.ntnu.no (Postfix, from userid 2312)
	id A9E89D0034; Fri, 13 Jul 2007 16:08:42 +0200 (CEST)
Date: Fri, 13 Jul 2007 16:08:42 +0200
From: Ulf Lilleengen <lulf@FreeBSD.org>
To: Sonja Milicic <smilicic@FreeBSD.org>
Message-ID: <20070713140842.GA5140@stud.ntnu.no>
References: <200707131310.l6DDAHSO085838@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200707131310.l6DDAHSO085838@repoman.freebsd.org>
User-Agent: Mutt/1.5.9i
X-Content-Scanned: with sophos and spamassassin at mailgw.ntnu.no.
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 123439 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jul 2007 14:10:35 -0000

On fre, jul 13, 2007 at 01:10:17 +0000, Sonja Milicic wrote:
> http://perforce.freebsd.org/chv.cgi?CH=123439
> 
> Change 123439 by smilicic@tanarri_marilith on 2007/07/13 13:09:48
> 
> 	added license statements to files that didn't have them
> 	   fixed a bug in g_log_access
> 	   redirecting write requests to log file now works
> 
> Affected files ...
> 
> .. //depot/projects/soc2007/smilicic_glog/sys/geom/log/geom_log_so.c#2 edit
> .. //depot/projects/soc2007/smilicic_glog/sys/geom/log/glog.c#7 edit
> .. //depot/projects/soc2007/smilicic_glog/sys/geom/log/glog_fileops.c#2 edit
> .. //depot/projects/soc2007/smilicic_glog/sys/geom/log/glog_fileops.h#2 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2007/smilicic_glog/sys/geom/log/geom_log_so.c#2 (text+ko) ====
> 
>  
*SNIP*
>  	    bp->bio_to->error, bp->bio_to->name));
>  
>  	G_LOG_LOGREQ(DBG_NOTICE, bp, "Request received.");
> -	g_io_deliver(bp, ENXIO);
> -	return;
>  	switch(bp->bio_cmd) {
>  	case BIO_WRITE:
> +		G_LOG_DEBUG(0, "Write request received.");
>  		g_log_post_event(&sc->sc_events, GLOG_EVWRITE, GLOG_FLAG_WAKEUP_SC, bp, 0);
>  		break;
>  	case BIO_READ:
> +		g_io_deliver(bp, ENXIO);
> +		return;
>  		g_log_post_event(&sc->sc_events, GLOG_EVREAD, GLOG_FLAG_WAKEUP_SC, bp, 0);
This will never be reached.

>  		break;
>  	default:
> -		break;
> +		g_io_deliver(bp, ENXIO);
> +		return;
>  	}
*SNIP*
> -	}
> +	
> +	err = g_access(cp, dr ,dw, de);
> +	
> +	G_LOG_DEBUG(0, "access done, %d", err);
>  	return err;
Just a quick note from style(9): return values should be enclosed in parantheses
like this: return (err);
>  }
*SNIP*

-- 
Ulf Lilleengen