Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Feb 2014 15:24:46 GMT
From:      Benjamin Podszun <dar@darklajid.de>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/186533: Update security/luasec to 0.5
Message-ID:  <201402071524.s17FOkUe032563@oldred.freebsd.org>
Resent-Message-ID: <201402071530.s17FU0wG065942@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         186533
>Category:       ports
>Synopsis:       Update security/luasec to 0.5
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 07 15:30:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Benjamin Podszun
>Release:        10.0-Release
>Organization:
>Environment:
FreeBSD dar-klajid.de 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014     root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Luasec recently (after some pressure, some projects even forked the library just to get a new release out of the door) released 0.5

Since I'm interested in net-im/prosody, which depends on security/luasec, I would like to see this update land in FreeBSD.

The patch attached builds fine on my system and I'm successfully running prosody with this version of security/luasec. portlint complains only about minor issues:

Only one master site: That's.. a lie. Yes, one URL. But Github and a CDN hiding behind that address

No ftp/http mirrors for user behing proxies: No idea what to do about that.

License not set: I'm not sure, I'd guess that is a variation of the BSD license, but don't want to make that call

I enabled staging support - the package seems to build/install fine without the opt-out.

If no one cares enough about this port I'd gladly volunteer to take it over - prosody (and therefor luasec) is a core part of what I'm using FreeBSD for. 
>How-To-Repeat:
$ pkg search luasec
lua51-luasec-0.4

>Fix:
Apply attached patch.

Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 343248)
+++ Makefile	(working copy)
@@ -2,9 +2,9 @@
 # $FreeBSD$
 
 PORTNAME=	luasec
-PORTVERSION=	0.4
+PORTVERSION=	0.5
 CATEGORIES=	security
-MASTER_SITES=	http://www.inf.puc-rio.br/~brunoos/luasec/download/
+MASTER_SITES=	https://github.com/brunoos/${PORTNAME}/archive/
 PKGNAMEPREFIX=	${LUA_PKGNAMEPREFIX}
 
 MAINTAINER=	ports@FreeBSD.org
@@ -12,15 +12,17 @@
 
 RUN_DEPENDS+=	${LUA_MODLIBDIR}/socket/core.so:${PORTSDIR}/net/luasocket
 
+FETCH_ARGS=	-Fpr
+WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTNAME}-${PORTVERSION}
+
 ALL_TARGET=	bsd
-LIBDIR=		-L${LUA_LIBDIR}
-MAKE_ENV+=	INCDIR=-I${LUA_INCDIR} LUAPATH=${LUA_MODSHAREDIR} \
+LIBDIR=		-L${LUA_LIBDIR} -L./luasocket
+MAKE_ENV+=	INCDIR="-I${LUA_INCDIR} -I${WRKSRC}/src" LUAPATH=${LUA_MODSHAREDIR} \
 		CPATH=${LUA_MODLIBDIR}
 USE_LUA=	5.1
 WANT_LUA_VER=	5.1
 USE_OPENSSL=	yes
 
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
 # NOTE: OSVERSION is already defined here, and USE_OPENSSL_PORT
@@ -31,10 +33,12 @@
 .endif
 
 post-patch:	.SILENT
-	${REINPLACE_CMD} -Ee '/^CC/s/=/?=/' \
-		-e '/^LD/s/gcc/$$(CC)/' \
-		-e '/^(C|LD)FLAGS/s/=/+=/' \
-		-e '/^BSD/{s/-O[0-3]?//;}' \
+	${REINPLACE_CMD} -Ee '/\(INSTALL\)/s/-D //' \
+		-e '/^LDFLAGS/s/\+=/=/' \
+		-e 's/LUAPATH/LUA_MODSHAREDIR/' \
+		-e 's/LUACPATH/LUA_MODLIBDIR/' \
 		${WRKSRC}/src/Makefile
+	${REINPLACE_CMD} -Ee '/^(INC|LIB)DIR/s/[^?]=/?=/' \
+		${WRKSRC}/Makefile
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
--- distinfo	(revision 343248)
+++ distinfo	(working copy)
@@ -1,2 +1,2 @@
-SHA256 (luasec-0.4.tar.gz) = 111732f0e646120a701d33e7d3a613a9a901c11c0a01d0805d73ef90c3f0abd5
-SIZE (luasec-0.4.tar.gz) = 27829
+SHA256 (luasec-0.5.tar.gz) = 6480598f7492ac479b6b608b5fb1488226bfa6ef675e29f6b24dbe9099083523
+SIZE (luasec-0.5.tar.gz) = 46738


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402071524.s17FOkUe032563>