From owner-cvs-all Fri Sep 14 11:28:14 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by hub.freebsd.org (Postfix) with ESMTP id 1163B37B40B for ; Fri, 14 Sep 2001 11:28:09 -0700 (PDT) Received: (qmail 54998 invoked from network); 14 Sep 2001 18:28:07 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 14 Sep 2001 18:28:07 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200109141610.JAA19037@windsor.research.att.com> Date: Fri, 14 Sep 2001 11:28:01 -0700 (PDT) From: John Baldwin To: Bill Fenner Subject: Re: Proposed patch to log_accum.pl Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org, joe@tao.org.uk Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 14-Sep-01 Bill Fenner wrote: > >>I think that Greg and others were proposing having a '0' without a >>leading '-' or '+'. I prefer an 'x' or other character to make it >>clear. > > There's also the possibility of "-0" on a new file (it's true, no > previously-existing lines were deleted) and "+0" on a removed file > (it's true, no new lines were added). That doesn't allow you to distinguish from the case when you just remove X number of lines from the file though. I think that hte first proposal is the most readable, and is unique, albeit slightly harder for scripts, but not that much, if the first of the 2 numbers starts with - instead of +, you know you have a file removal, and if the second string doesnt' start with -, you have a file addition, so it's not but so hard to parse and makes much more sense to human eyes: 1.1 +145 src/foo.c 1.67 -69 src/bar.c 1.3 +4 -3 src/baz.c -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message