From owner-freebsd-arch@freebsd.org  Fri May 15 16:58:44 2020
Return-Path: <owner-freebsd-arch@freebsd.org>
Delivered-To: freebsd-arch@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id ACDF72FA87E
 for <freebsd-arch@mailman.nyi.freebsd.org>;
 Fri, 15 May 2020 16:58:44 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 49NvkX49Mcz46sJ;
 Fri, 15 May 2020 16:58:44 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com
 [209.85.222.172])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 7C83A1C806;
 Fri, 15 May 2020 16:58:44 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-qk1-f172.google.com with SMTP id f83so3204736qke.13;
 Fri, 15 May 2020 09:58:44 -0700 (PDT)
X-Gm-Message-State: AOAM532g0pDKHsuxIkIwibIcGjLp6y6ME1H3O9+pKNXZ5Bk2lDIFiOQV
 sDvWgjcOQNp+ysJfyv3uOL3sW8KxO9Mt2G4MhmE=
X-Google-Smtp-Source: ABdhPJx76+1zftOBLi+9PqC9yAFU1dVRrJjm++GqlGBrpFoH4u+VKConhu5MCeh3iyc81ThrFS2a2qdRVLxVbcWRTxY=
X-Received: by 2002:a37:8c4:: with SMTP id 187mr4376247qki.34.1589561924140;
 Fri, 15 May 2020 09:58:44 -0700 (PDT)
MIME-Version: 1.0
References: <CACNAnaFszg+QWPRS0kghsnQMxXc+5niPTTNiUPSmK60YyBGCzA@mail.gmail.com>
In-Reply-To: <CACNAnaFszg+QWPRS0kghsnQMxXc+5niPTTNiUPSmK60YyBGCzA@mail.gmail.com>
From: Kyle Evans <kevans@freebsd.org>
Date: Fri, 15 May 2020 11:58:30 -0500
X-Gmail-Original-Message-ID: <CACNAnaFE6gzyvwc8kbrX8Oq-h_acVq7wqgQ1P=a3jNpFBGshGw@mail.gmail.com>
Message-ID: <CACNAnaFE6gzyvwc8kbrX8Oq-h_acVq7wqgQ1P=a3jNpFBGshGw@mail.gmail.com>
Subject: Re: [HEADSUP] Disallowing read() of a directory fd
To: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org>
Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>,
 Poul-Henning Kamp <phk@phk.freebsd.dk>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 May 2020 16:58:44 -0000

On Thu, May 14, 2020 at 1:26 PM Kyle Evans <kevans@freebsd.org> wrote:
>
> Hi,
>
> This is a heads up, given that I'm completely flipping our historical
> behavior- I intend to commit this review in a couple days' time
> without substantial objection: https://reviews.freebsd.org/D24596
>

Note that the review has been updated to reflect feedback received
through the course of this discussion. The current version, as of the
time of writing, instead adds a security.bsd.allow_read_dir
(defaulting to off) that will allow the system root (*not* jailed
root) the ability to read(2) a directory if the filesystem supports
it. A new priv(9), PRIV_VFS_READ_DIR has been added so that anyone
interested in expanding the scope of the sysctl beyond the system root
is welcome to implement a MAC policy for it.

rgrimes@ and phk@ have been specifically invited to the review as
representatives of those opposing the original change, but of course
anyone is free to add themselves and/or simply chime in with
constructive objections.

Thanks,

Kyle Evans