From owner-svn-src-all@FreeBSD.ORG  Sat Oct  6 21:39:12 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 51F9C1065672;
	Sat,  6 Oct 2012 21:39:12 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 073188FC17;
	Sat,  6 Oct 2012 21:39:11 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:d16d:2274:8c10:a1ca] (unknown
	[IPv6:2001:7b8:3a7:0:d16d:2274:8c10:a1ca])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id D15F15C59;
	Sat,  6 Oct 2012 23:39:04 +0200 (CEST)
Message-ID: <5070A4FC.4080802@FreeBSD.org>
Date: Sat, 06 Oct 2012 23:39:08 +0200
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:16.0) Gecko/20121002 Thunderbird/16.0
MIME-Version: 1.0
To: Marcel Moolenaar <marcel@FreeBSD.org>
References: <201210062001.q96K16Or030755@svn.freebsd.org>
In-Reply-To: <201210062001.q96K16Or030755@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r241298 - in head: . gnu/usr.bin/cc/cc_int
 gnu/usr.bin/cc/include
 kerberos5 kerberos5/tools/asn1_compile kerberos5/tools/slc lib/clang/include
 share/mk tools/build/make_check usr.sbin/c...
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Oct 2012 21:39:12 -0000

On 2012-10-06 22:01, Marcel Moolenaar wrote:
>    2.  Remove the use of -E. It's not needed in our build because we use ?= for
>        the respective variables, which means that we'll take the environment
>        value (if any) anyway.

No, this will break builds of 32-bit libraries on amd64, at least when
CC/CXX etc are set in make.conf.  I put this in specifically in r227120.

Please revert this particular change, unless you have tested that it
works correctly, with e.g.  CC=clang in make.conf.