From owner-freebsd-hackers@FreeBSD.ORG Wed Feb 2 18:56:35 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A109106566C for ; Wed, 2 Feb 2011 18:56:35 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 074648FC22 for ; Wed, 2 Feb 2011 18:56:34 +0000 (UTC) Received: by eyf6 with SMTP id 6so258187eyf.13 for ; Wed, 02 Feb 2011 10:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=5fXJWCtiZSiGSdeB9whkxytPJE++BV4L22cDBfJHRVs=; b=USmS78Ogmp3dvVo1XiP8ZaTEvxh+QWKAwcE6GB7WWjtMIsH8dNMHT0QsxkOY+yHb6h HaWMyd+Vx+zZrqqIwppUKDZvf6z1rkK3x9zoLxh6d0PTkW+1Whiebt+NheYkm+0nemtR bI1Gs+CRstCd6pxXXjVTkgNfTiO9KZ41AaFTE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=iAUC0LzLgw/4K1EcXDSxFi9ynY1DFzVb85JprDTvOQKF4QHsMmD39uvQd4wMpiES3n 7N+5negln25DDW46L+/Na9USV2eM4Yz9klcdS9lFc8NudQY6nDYc7atVq1thgjA0JKR+ RGgKb9cA7bA2j0ET3+s9crJaePZ0b8cZRqBnk= Received: by 10.213.35.209 with SMTP id q17mr11551779ebd.53.1296671481733; Wed, 02 Feb 2011 10:31:21 -0800 (PST) Received: from localhost (tor-exit-readme.hands.com [83.142.228.14]) by mx.google.com with ESMTPS id t50sm18424577eeh.6.2011.02.02.10.31.17 (version=SSLv3 cipher=RC4-MD5); Wed, 02 Feb 2011 10:31:20 -0800 (PST) From: Anonymous To: Alexander Best References: <20110106014046.GA324@freebsd.org> <20110202172010.GA17563@freebsd.org> Date: Wed, 02 Feb 2011 21:30:55 +0300 In-Reply-To: <20110202172010.GA17563@freebsd.org> (Alexander Best's message of "Wed, 2 Feb 2011 17:20:10 +0000") Message-ID: <867hdijnkw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: freebsd-hackers@freebsd.org, Sergey Kandaurov Subject: Re: broken INCLUDE in sys/conf/kern.pre.mk for opensolaris code? X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Feb 2011 18:56:35 -0000 Alexander Best writes: > On Wed Feb 2 11, Sergey Kandaurov wrote: >> On 6 January 2011 04:40, Alexander Best wrote: >> > hi there, >> > >> > while building target buildkernel with 'clang -v' i noticed a lot of these >> > lines: >> > >> > ignoring nonexistent directory "/usr/subversion-src/sys/contrib/opensolaris/compat" >> > >> > i checked sys/conf/kern.pre.mk and there's a line refering to a non-existing >> > directory: >> > >> > # ... and OpenSolaris >> > INCLUDES+= -I$S/contrib/opensolaris/compat >> >> Hi, I just removed that path in r218189. > > thanks a bunch. :) > > i might do a 'make universe' build at some point with clang -v in order to > check, if there are more cases where non-existing include paths exist in the > freebsd src. -Wmissing-include-dirs (with -Werror) is there to catch such cases. Try to add it to CWARNFLAGS and see if universe build passes. Note, clang doesn't support it and it's broken in our gcc but there is a simple fix, unfortunately, under gplv3.