Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 04 Sep 2014 09:16:49 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 193185] [stage] net/ipsorc   MASTER_SITES LICENSE WWW take maintainership
Message-ID:  <bug-193185-13-xx2wJ8yFsK@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-193185-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-193185-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193185

--- Comment #15 from C Hutchinson <portmaster@bsdforge.com> ---
(In reply to John Marino from comment #13)
> (In reply to C Hutchinson from comment #11)
> > Well that would explain it.
> > I always use 4. But NP, I can live with it. Thanks for pointing it out.
> 
> /me bands head against wall.
> 
> If the issue was just affecting you, I wouldn't care.  But we've seen that
> it affects your submissions, which means it affects everyone that deals with
> the PR it's submitted on.
> 
> So I said, "Use tab=8 always, and you say you'll stick with 4 and deal". 
> That tells me more mis-tabs are coming.  And once you have a reputation for
> being sloppy, people are going to pass your PRs for those contributors that
> pay attention to detail.  e.g. there are 10 PRs and you have time to pick up
> one.  Are you going to pick up the PR from the guy with the great
> reputation, or the guy whose PRs always have issues?  Even if they are only
> cosmetic issues?  Think about it.

Not true. Well, OK, true too.
But.
I can see the pattern(s) here. Especially now _knowing_ that
most of the ports files are in an 8-space tab format. I can
easily count, and you have also noted their [preferred] numbers.
So long as I use the correct count, everyone will be happy. No?

I have no intention, nor desire to be "sloppy". But I think
everyone can win, in this particular case. No?

Thanks, John. Points well taken. :)

--Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193185-13-xx2wJ8yFsK>