Date: Thu, 10 Dec 2015 16:35:09 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Randall Stewart <rrs@netflix.com> Cc: "Alexander V. Chernikov" <melifaro@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, freebsd-net <freebsd-net@freebsd.org>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: panic in arptimer in r289937 Message-ID: <56699BAD.9090208@selasky.org> In-Reply-To: <96B619F6-489C-4931-B306-1E1DE03F09B4@netflix.com> References: <CAJ-VmonvVyTNuYv_as41yPCFdfR5T3FE45DP9MKAc-eyzXzPUg@mail.gmail.com> <2739461446298483@web2h.yandex.ru> <CAJ-Vmo=JjHonDqOYK%2BJDaf9581dRU5_KoaSTnY27JnzQm0v56w@mail.gmail.com> <1733241446303675@web19h.yandex.ru> <5661EAAF.1010906@selasky.org> <5661EF10.8060300@selasky.org> <96B619F6-489C-4931-B306-1E1DE03F09B4@netflix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/10/15 16:25, Randall Stewart wrote: > For callout_stop/drain you get > > -1 == Callout as already gone off or is not running (usually the latter) else the caller iks > not using locking properly or did not lock and check the active() value (which would have returned not active so no stop > would have been needed); > 0 == we could not stop the callout, it was in process.. > 1 == it was stopped successfully > > > For callout_reset() you get > > 0 == it was started > 1 == it was restarted. > > There is no -1 since it is either started or restarted never left in a not-running state... > Hi, Correct, though if the return values would be the same, it might simplify the callout API and manual page a bit: /* return values for all callout_xxx() functions */ #define CALLOUT_RET_DRAINING 0 /* callout cannot be stopped, need drain */ #define CALLOUT_RET_CANCELLED 1 /* callout was successfully stopped */ #define CALLOUT_RET_STOPPED -1 /* callout was already stopped */ Then callout_reset() would return -1, if it was started from the stopped state. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56699BAD.9090208>