From nobody Fri Jan 9 23:04:33 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dny636rjkz6MWTs for ; Fri, 09 Jan 2026 23:04:59 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dny634Jw5z3k7b for ; Fri, 09 Jan 2026 23:04:54 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-64b83949fdaso7727990a12.2 for ; Fri, 09 Jan 2026 15:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767999887; x=1768604687; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GW6mDVJ7uP6LyU8cUen2ZlrV576K4qt85EajDk2p2HE=; b=IYeFtKbnJVUioUDtCVB0V2wIMmkc7Idd0l3Vxixe1TYi9LjGa2UqXmyOQZWLoi3v5t cTCt9UyDvvlrKcmuKaofDZAhowCN2PMSUDP7UVKK01kX7/AuJ5s2ro+r7oSADCuRUVVI HjpQeS2AwU23c3GUBnewjrSIZkRegMWMD3WN7CQ/aKwK10N/luQj2vtSjxz6nhBKKnXW hAJb5ACWHlulIfQYYxmufzCVab1ZQg2U5gNsRpDRcoASnnhKqxy3verHXE3eQJ8n8cbQ fIUuC/63vZrVLb4jYHjFN+CHzoKytu7weVKXAIR3rgcCldrvu1rOApNsewCrrVl8JVhm DRpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767999887; x=1768604687; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GW6mDVJ7uP6LyU8cUen2ZlrV576K4qt85EajDk2p2HE=; b=uuiszwVRa3c5U3gBVGXRa8fgWidebwYUh07W7PNuP+W03CJUcDox25OPXCNEXNkD1p J9WK+39JdClIKpJi3yubpT7mmUxAmc9QsUphR+ekn4w/InfnEekGapuyuqKRhQRS6+TX O5xlzz/4zNKMgf1wC5lUnm7MFzhwuPWNPSPmA76zN26tXrztqTq+cc7u9mSs5c/XK/Ad puPqdNUNMb9eQLiPlzejGHatvylJXpCuc+ssy0f/GwB/+4oq6jrrDCVq/XdcJfPGh7dB nYLfNy2u9epxM33tADwNaap/16ca2u8SwMLgsN1Xf1NNfgxl0qGdhiDGbm25cxjeNc26 RT4Q== X-Forwarded-Encrypted: i=1; AJvYcCUdx12drKvjivDWUwNo0/W3IYuWSpIt26hZA8NIbEBWRYwmFaZO2b6zDQxg2ZSWb4nGe2FBGkEoAV+Kics2X7jHqDqbWQ==@freebsd.org X-Gm-Message-State: AOJu0YwYBJPJG2/gq7UYPAe61SXQiy8v2ie95MrkMkzuR2/oVgbhoG3L RAoRvQ76G+5dKMkVsK0eJF9kpkdgI5cF3GvI1cjZNgVMfcvw4y2qnk2zp6EcAsgfJwGKOicRGZH r8n1/8Zsz2LI6RIL+JXBmWsOZxCRKJw== X-Gm-Gg: AY/fxX65obGi/D6Kn/liVC+SMRwaRQSAkIWi5eeJmuRMM9Nix3/fw/Xg+IODaGvXQf5 kgV7VtIVWX/IZvYqfcJaTpdrVvNDMSD177VWnjGFWnZdjFBqj8iWZQuqs3vdmIWRlhDKjr4jtvc Ucg1aCleZMWwXGoaFlbBUOx7uYhH43QtMddz9WlJML9q+i4o1DQEd97Ywd5Frw41hEmfSjfzvNG 66kzHh2K3vXfHJLqH8aEsg76K7PPujQLs7InCOh89bwSiFJ2wZ19Wq4vdoeTsYc/873eJYYGHFW 3ktNPkIF1yBLWCg56GjoR336MABB X-Google-Smtp-Source: AGHT+IEEDFa24qhneQR7MgNabmBZk+s/5mgb2sSYUICMt8Hy13dY/l1BEZl4f9EoL/Nm2Ws4qhuQUUNx29MCTQaeb2s= X-Received: by 2002:a05:6402:40ca:b0:64b:7fbb:fbd6 with SMTP id 4fb4d7f45d1cf-65097e8abf4mr11366902a12.28.1767999886896; Fri, 09 Jan 2026 15:04:46 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <69604cd7.3aebd.7fdcb739@gitrepo.freebsd.org> In-Reply-To: From: Rick Macklem Date: Fri, 9 Jan 2026 15:04:33 -0800 X-Gm-Features: AZwV_QgM7MnAlV6HOD6fzzou3RQt_OKE-NEl09Mm1spsHnk2X6fGPbG4SvtXwmI Message-ID: Subject: Re: git: a6d57f312f18 - main - nfsd: Fix handling of hidden/system during Open/Create To: Benjamin Kaduk Cc: Rick Macklem , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dny634Jw5z3k7b On Fri, Jan 9, 2026 at 11:56=E2=80=AFAM Benjamin Kaduk = wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > On Thu, Jan 8, 2026 at 4:33=E2=80=AFPM Rick Macklem wrote: >> >> The branch main has been updated by rmacklem: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Da6d57f312f18bbeeda8a34e99= d0a662b0db9a190 >> >> commit a6d57f312f18bbeeda8a34e99d0a662b0db9a190 >> Author: Rick Macklem >> AuthorDate: 2026-01-08 16:27:32 +0000 >> Commit: Rick Macklem >> CommitDate: 2026-01-08 16:27:32 +0000 >> >> nfsd: Fix handling of hidden/system during Open/Create >> >> When an NFSv4.n client specifies settings for the archive, >> hidden and/or system attributes during a Open/Create, the >> Open/Create fails for ZFS. This is caused by ZFS doing >> a secpolicy_xvattr() call, which fails for non-root. >> If this check is bypassed, ZFS panics. >> >> This patch resolves the problem by disabling va_flags >> for the VOP_CREATE() call in the NFSv4.n server and >> then setting the flags with a subsequent VOP_SETATTR(). >> > > The diff doesn't really include enough context to tell -- does this intro= duce a race window where a file that's supposed to be hidden and/or system = is visible without that attribute from a different process? I believe that the answer is no. VOP_CREATE() returns the new file's vnode exclusively locked and the update via VOP_SETATTR() happens before the vnode lock is released. rick > > Thanks, > > Ben