From owner-freebsd-amd64@FreeBSD.ORG  Tue Apr  5 19:00:06 2005
Return-Path: <owner-freebsd-amd64@FreeBSD.ORG>
Delivered-To: freebsd-amd64@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3304B16A4CE; Tue,  5 Apr 2005 19:00:06 +0000 (GMT)
Received: from isis.sigpipe.cz (r2g224.chello.upc.cz [62.245.70.224])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DBCA743D46; Tue,  5 Apr 2005 19:00:02 +0000 (GMT)
	(envelope-from neuhauser@sigpipe.cz)
Received: by isis.sigpipe.cz (Postfix, from userid 1001)
	id DBE451F87BED; Tue,  5 Apr 2005 21:00:01 +0200 (CEST)
Date: Tue, 5 Apr 2005 21:00:01 +0200
From: Roman Neuhauser <neuhauser@sigpipe.cz>
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
Message-ID: <20050405190001.GA23554@isis.sigpipe.cz>
Mail-Followup-To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>,
	freebsd-amd64@freebsd.org, ports@freebsd.org
References: <Pine.BSF.4.53.0504051754330.81515@e0-0.zab2.int.zabbadoz.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.BSF.4.53.0504051754330.81515@e0-0.zab2.int.zabbadoz.net>
User-Agent: Mutt/1.5.6i
cc: ports@freebsd.org
cc: freebsd-amd64@freebsd.org
Subject: Re: [patch|test] CVSup/amd64
X-BeenThere: freebsd-amd64@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting FreeBSD to the AMD64 platform <freebsd-amd64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-amd64>
List-Post: <mailto:freebsd-amd64@freebsd.org>
List-Help: <mailto:freebsd-amd64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Apr 2005 19:00:06 -0000

# bzeeb-lists@lists.zabbadoz.net / 2005-04-05 18:13:14 +0000:
> attached patch also available at
> http://sources.zabbadoz.net/freebsd/ports/experimental/cvsup-amd64.diff
> updates binary only port for amd64.

> @@ -73,6 +71,10 @@ M3FLAGS+=	-DSTATIC
>  pre-fetch:
>  .ifndef WITHOUT_X11
>  	@${ECHO_MSG} "*****************************************************"
> +.if ${ARCH} == "amd64"
> +	@${ECHO_MSG} "* CVSup with X11 not yet supported on amd64.        *"
> +	@${ECHO_MSG} "* Will install non-X11 version. You might want      *"
> +.endif
>  	@${ECHO_MSG} "* To build CVSup without X11 (and without the GUI), *"
>  	@${ECHO_MSG} "* use the \"net/cvsup-without-gui\" port.             *"
>  	@${ECHO_MSG} "*****************************************************"

Hmm, this doesn't look very natural:

    CVSup with X11 not yet supported on amd64.
    Will install non-X11 version. You might want
    To build CVSup without X11 (and without the GUI),
    use the "net/cvsup-without-gui" port.

And it's misleading, too: it won't actually build anything. This is better:

@@ -73,10 +71,15 @@
 pre-fetch:
 .ifndef WITHOUT_X11
        @${ECHO_MSG} "*****************************************************"
+.if ${ARCH} == "amd64"
+       @${ECHO_MSG} "* CVSup with X11 not yet supported on amd64.        *"
+       @${ECHO_MSG} "* This port will install the non-X11 version.       *"
+.else
        @${ECHO_MSG} "* To build CVSup without X11 (and without the GUI), *"
        @${ECHO_MSG} "* use the \"net/cvsup-without-gui\" port.             *"
+.endif
        @${ECHO_MSG} "*****************************************************"
 .endif
        @${TRUE}
 
 post-install:


-- 
How many Vietnam vets does it take to screw in a light bulb?
You don't know, man.  You don't KNOW.
Cause you weren't THERE.             http://bash.org/?255991