From owner-freebsd-stable@FreeBSD.ORG Fri Jan 1 15:12:50 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D1CC210656F8 for ; Fri, 1 Jan 2010 15:12:50 +0000 (UTC) (envelope-from dhorn2000@gmail.com) Received: from mail-fx0-f227.google.com (mail-fx0-f227.google.com [209.85.220.227]) by mx1.freebsd.org (Postfix) with ESMTP id 646B48FC12 for ; Fri, 1 Jan 2010 15:12:50 +0000 (UTC) Received: by fxm27 with SMTP id 27so12683726fxm.3 for ; Fri, 01 Jan 2010 07:12:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=rq5NYhwhh1C/Hy+JUYqyO2RH3m231N20770d8zoWeuw=; b=euy6iDpY5JKtzdnUr/eJkmtm3n/j0ACOF2KD8tLYQNoI1N/DdyyrSkCy6+oLJp8mKi cL6yIGzldV3v7GgBDv4f4ItPFd6r8kfjGyuVXRCoSFwAJXNgDXSPGA6Uktb60Dn/QXdH dUlhHR3ksR8g8OWg+XyplK9VgngD8wYD42Z08= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=VW6FdSXfx+DVekXl7XY9jzK6HlkArVtzgHhquhut/urPj48i8jGvzaVYq37wi0/fAZ EfnFWGP4MxJqWBGeZa0DnOWLwotIu3WfTQE9fhMIMZdpA1ex5OfVa46W7/9fE4pw9FeC 2dEGF2M8snf0l+j6V2QctjUajWJuIJVFWLn30= MIME-Version: 1.0 Received: by 10.239.145.133 with SMTP id s5mr292530hba.49.1262358761646; Fri, 01 Jan 2010 07:12:41 -0800 (PST) In-Reply-To: <20100101152827.8eabdf9e.usselmann.m@icg-online.de> References: <20091213103237.d01b51f2.usselmann.m@icg-online.de> <25ff90d60912132123x77198b1o6bfad3bffe0d01a0@mail.gmail.com> <20091214081716.f6e96b85.usselmann.m@icg-online.de> <20091214233123.a5b178c2.usselmann.m@icg-online.de> <25ff90d60912141451y50137b09qa2d5c380093dd8d5@mail.gmail.com> <20100101152827.8eabdf9e.usselmann.m@icg-online.de> Date: Fri, 1 Jan 2010 10:12:41 -0500 Message-ID: <25ff90d61001010712r28f68ddeyd1fb1164be0c9091@mail.gmail.com> From: David Horn To: Manfred Usselmann Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-stable@freebsd.org Subject: Re: duplicity ftp backup / ncftp no longer working since 8.0-Release X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2010 15:12:51 -0000 On Fri, Jan 1, 2010 at 9:28 AM, Manfred Usselmann wrote: > On Mon, 14 Dec 2009 17:51:31 -0500 > David Horn wrote: > >> On Mon, Dec 14, 2009 at 5:31 PM, Manfred Usselmann >> wrote: >> > On Mon, 14 Dec 2009 08:17:16 +0100 >> > Manfred Usselmann wrote: >> > >> >> On Mon, 14 Dec 2009 00:23:17 -0500 >> >> David Horn wrote: >> >> >> >> > I believe that there is something unusual going on with the checkin= g >> >> > on select() return in ncftp3. =A0If you change every instance of >> >> > select() result checking in ftp/ncftp3 from "=3D=3D1" to ">=3D1" th= e problem >> >> > seems to go away. >> >> > >> >> > result =3D select(sfd + 1, NULL, SELECT_TYPE_ARG234 &ss, NULL, >> >> > SELECT_TYPE_ARG5 &tv); >> >> > -if (result =3D=3D 1) { >> >> > +if (result >=3D 1) { >> >> >> >> I will try this. >> > >> > Did work for me! >> > >> > Thanks, >> > Manfred >> >> OK. =A0 I will try to report it to the upstream (ncftp.com/contact), and >> failing that we could always patch as part of the ncftp 3.2.3 update >> into freebsd ports, but glad to hear it worked for you. > > The port has been updated to 3.2.3 but without a fix. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D140934 mentions a fix to > FreeBSD 8 which sounds like it should have solved our issue. Don't know > why it didn't. > > Regards, > Manfred > 3.2.3 of ncftp was released by the vendor in July 2009 (http://www.ncftp.org/), so it would not have yet incorporated the select() result checking changes. I reported the issue to ncftp, and they acknowledged the issue. I can only assume that it will be addressed in the next vendor release (3.2.4 ?) The obrien change was a patch to the freebsd ncftp port (3.2.2) for the same issue, but only on one of the select() instances (not all of them). http://www.freebsd.org/cgi/cvsweb.cgi/ports/ftp/ncftp3/files/Attic/patch-SC= onnect.c The obrien commit was since reverted for 3.2.3 since the vendor included the one instance of select() result checking in the base code. So, long story short, you still need to manually patch the source of ncftp until either A) Vendor updates base code (or) B) Someone submits a patch to the freebsd port of ftp/ncftp3 (3.2.3) If you are really concerned about it, create an official patch (use diff -u) and attach it to your bug report. Bug reports with patches are much more likely to see action. If you are having issues creating a patch let me know and I will try to find the time to do this in the next week or so. (ENOTIME) Good Luck. ---Dave Horn