Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Nov 2004 22:16:49 GMT
From:      Thierry Thomas <thierry@FreeBSD.org>
To:        cartola@openit.com.br, thierry@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org, thierry@FreeBSD.org
Subject:   Re: ports/72806: New port: deskutils/freemind - Freemind is an incredible thought organization tool - a mind map software
Message-ID:  <200411112216.iABMGnRh035660@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
Synopsis: New port: deskutils/freemind - Freemind is an incredible thought organization tool - a mind map software

State-Changed-From-To: open->feedback
State-Changed-By: thierry
State-Changed-When: Thu Nov 11 22:08:07 GMT 2004
State-Changed-Why: 

Please consider the following patch, which makes some cleaning:

diff -urN deskutils/freemind.orig/Makefile deskutils/freemind/Makefile
--- deskutils/freemind.orig/Makefile	Thu Nov 11 22:44:17 2004
+++ deskutils/freemind/Makefile	Thu Nov 11 23:00:29 2004
@@ -1,61 +1,33 @@
-# New ports collection makefile for:   freemind
-# Date created:        22 september 2004
-# Whom:                cartola (Carlos E. G. Carvalho)
+# New ports collection makefile for:	freemind
+# Date created:	 22 september 2004
+# Whom:		cartola (Carlos E. G. Carvalho)
 #
 # $FreeBSD$
 #
-# Freemind is an incredible thought organization tool
-#
-# FROM THE AUTHORS:
-#
-# FreeMind is a premier free mind-mapping software written in Java. The
-# recent development has hopefully turned it into high productivity
-# tool. We are proud that the operation and navigation of FreeMind is
-# faster than that of Mind Manager because of one-click "fold / unfold"
-# and "follow link" operations.
-#
-# So you want to write a completely new metaphysics? Why don't you use
-# FreeMind? You have a tool at hand that remarkably resembles the tray
-# slips of Robert Pirsig, described in his sequel to Zen and the Art of
-# Motorcycle Maintenance called Lila. Do you want to refactor your essays
-# in a similar way you would refactor software? Or do you want to keep
-# personal knowledge base, which is easy to manage? Why don't you try
-# FreeMind? Do you want to priorize, know where you are, where you've been
-# and where you are heading, as Stephen Covey would advise you? Have you
-# tried FreeMind to keep track of all the things that are needed for that?
-#
-# FROM THE PORTER (me):
-#
-# Freemind is usable for many different things. I'm using it to plan
-# projects, document servers and systems, plan and do html presentations
-# guides, record and mantain progress of tasks and some other things.
-#
-
-PORTNAME=      freemind
-PORTVERSION=   0.7.1
-CATEGORIES=    deskutils java
-MASTER_SITES=          ${MASTER_SITE_SOURCEFORGE}
-MASTER_SITE_SUBDIR=    freemind
-DISTFILES=     freemind-bin-0_7_1.zip
-
-MAINTAINER=    cartola@openit.com.br
-COMMENT=       Free mind mapping software
-
-USE_ZIP=       yes
-USE_JAVA=      1.4+
 
-NO_BUILD=      yes
+PORTNAME=	freemind
+PORTVERSION=	0.7.1
+CATEGORIES=	deskutils java
+MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
+MASTER_SITE_SUBDIR=	freemind
+DISTNAME=	${PORTNAME}-bin-${PORTVERSION:S/./_/g}
+
+MAINTAINER=	cartola@openit.com.br
+COMMENT=	Free mind mapping software
+
+USE_ZIP=	yes
+USE_JAVA=	yes
+JAVA_VERSION=	1.4+
 
-do-extract:
-       @${MKDIR} ${WRKSRC}
-       ${UNZIP_CMD} -d ${WRKSRC} ${DISTDIR}/${DISTFILES}
+NO_BUILD=	yes
+EXTRACT_AFTER_ARGS=	-d ${WRKSRC}
 
 do-install:
-       ${CP} -r ${WRKSRC} ${PREFIX}
-       @(${ECHO} "#\!/bin/sh"; ${ECHO} "${JAVA_HOME}/bin/java -jar ${PREFIX}/${DISTNAME}/lib/freemind.jar \$@") > ${PREFIX}/bin/freemind
-       ${CHMOD} 755 ${PREFIX}/bin/freemind
-       @# Cleaning those dirs that are not necessary and give error
-       @# messages when removing package installed with package
-       @${RMDIR} ${PREFIX}/${DISTNAME}/doc/maps ${PREFIX}/${DISTNAME}/doc/pics
+	${CP} -r ${WRKSRC} ${PREFIX}
+	@(${ECHO} "#\!/bin/sh"; ${ECHO} "${JAVA_HOME}/bin/java -jar ${PREFIX}/${DISTNAME}/lib/freemind.jar \$@") > ${PREFIX}/bin/freemind
+	${CHMOD} 755 ${PREFIX}/bin/freemind
+	@# Cleaning those dirs that are not necessary and give error
+	@# messages when removing package installed with package
+	@${RMDIR} ${PREFIX}/${DISTNAME}/doc/maps ${PREFIX}/${DISTNAME}/doc/pics
 
 .include <bsd.port.mk>

Then, there is another problem: this port installs unnecessary
files, like a MS-Windows binary (Freemind.exe), a DOS batch file
(freemind.bat), or a non-executable shell script (freemind.sh).
Could you please remove them and check the remaining files?



Responsible-Changed-From-To: freebsd-ports-bugs->thierry
Responsible-Changed-By: thierry
Responsible-Changed-When: Thu Nov 11 22:08:07 GMT 2004
Responsible-Changed-Why: 

Handle.


http://www.freebsd.org/cgi/query-pr.cgi?pr=72806



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411112216.iABMGnRh035660>