From owner-freebsd-hackers@freebsd.org Sat Jan 13 17:34:41 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D1FCCE74E3A for ; Sat, 13 Jan 2018 17:34:41 +0000 (UTC) (envelope-from kevans91@ksu.edu) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0070.outbound.protection.outlook.com [104.47.42.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 717DC6E4DC for ; Sat, 13 Jan 2018 17:34:40 +0000 (UTC) (envelope-from kevans91@ksu.edu) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ksu.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=r3ZNasU7psAak8Igl91TekyMsnlxRdE31iBI/q3ZLPM=; b=rKos6BNG8T7T5vDEhddf3QaUuezni8wwXZIyFuQAR4qWCSnFlGLrfT1vyHNsZJ8YCLDkbjLc1fwMmBYIJi7/0bBDYBHcpIIsZ2DoEJsnLJ2p42dpIJbUydSYMpTmLCsIJAAcauKPdvh13TiXZ98gEG+hrI9I5jYVP1zFMkEHIxk= Received: from DM5PR05CA0004.namprd05.prod.outlook.com (10.173.226.14) by CY4PR05MB2983.namprd05.prod.outlook.com (10.169.184.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.428.9; Sat, 13 Jan 2018 17:34:39 +0000 Received: from CY1NAM02FT018.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::200) by DM5PR05CA0004.outlook.office365.com (2603:10b6:3:d4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.428.9 via Frontend Transport; Sat, 13 Jan 2018 17:34:38 +0000 Authentication-Results: spf=pass (sender IP is 129.130.18.151) smtp.mailfrom=ksu.edu; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=bestguesspass action=none header.from=ksu.edu; Received-SPF: Pass (protection.outlook.com: domain of ksu.edu designates 129.130.18.151 as permitted sender) receiver=protection.outlook.com; client-ip=129.130.18.151; helo=ome-vm-smtp1.campus.ksu.edu; Received: from ome-vm-smtp1.campus.ksu.edu (129.130.18.151) by CY1NAM02FT018.mail.protection.outlook.com (10.152.75.183) with Microsoft SMTP Server id 15.20.345.12 via Frontend Transport; Sat, 13 Jan 2018 17:34:38 +0000 Received: from calypso.engg.ksu.edu (calypso.engg.ksu.edu [129.130.43.181]) by ome-vm-smtp1.campus.ksu.edu (8.14.4/8.14.4/Debian-2ubuntu2.1) with ESMTP id w0DHYbbc017092 for ; Sat, 13 Jan 2018 11:34:38 -0600 Received: by calypso.engg.ksu.edu (Postfix, from userid 110) id C5B6C248316; Sat, 13 Jan 2018 11:34:37 -0600 (CST) Received: from mail-io0-f172.google.com (mail-io0-f172.google.com [209.85.223.172]) by calypso.engg.ksu.edu (Postfix) with ESMTPA id A514D248004 for ; Sat, 13 Jan 2018 11:34:35 -0600 (CST) Received: by mail-io0-f172.google.com with SMTP id d11so9112391iog.5 for ; Sat, 13 Jan 2018 09:34:35 -0800 (PST) X-Gm-Message-State: AKGB3mJg1NxsbrBs5TYh/742SfsAuZ15KdoyYq+sdxfVe3LqkPCyB+CX cR06WSM5sxvlSXKU9cbGk8du7Cb2DDy77am7hOo= X-Google-Smtp-Source: ACJfBovcqq7YcZRhcAiHuNJAQwfkbykgbgr7xriTAVF4L1eoIxwevV4KPns4b0WO8JS5GVI1fsAy8NBaTKaQ9CvfHjM= X-Received: by 10.107.21.65 with SMTP id 62mr28641680iov.148.1515864875086; Sat, 13 Jan 2018 09:34:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.149.147 with HTTP; Sat, 13 Jan 2018 09:34:14 -0800 (PST) In-Reply-To: References: From: Kyle Evans Date: Sat, 13 Jan 2018 11:34:14 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: 1 << 31 redux To: Eitan Adler CC: FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:129.130.18.151; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(346002)(39380400002)(376002)(396003)(39860400002)(2980300002)(438002)(189003)(199004)(53754006)(24454002)(75432002)(47776003)(61266001)(86362001)(59536001)(356003)(4326008)(106002)(6862004)(50466002)(88552002)(61726006)(55446002)(6246003)(229853002)(246002)(5820100001)(305945005)(2950100002)(2906002)(98316002)(106466001)(478600001)(9896002)(8676002)(5660300001)(23676004)(498394004)(8936002)(966005)(16586007)(95326003)(42186006)(90966002)(93516011)(9686003)(59450400001)(76176011)(316002)(33896004)(53546011)(786003)(6306002)(55456009); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR05MB2983; H:ome-vm-smtp1.campus.ksu.edu; FPR:; SPF:Pass; PTR:ip-18-151.net.ksu.edu; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT018; 1:+VEBK9rOfUbB1SeKvYyX+O9Vs/0DaXxmZuSL4mGkTK4fJey1nf9o3w9LDhinQwtWwjIoG69TvpJ6f8InmSwnIkXlWYT2eFT5fxQ05egp7xWFJHduAYLwc01WodmHyHD9 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f588e8e9-034a-4721-bcb4-08d55aabebd9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989060)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(8990040)(5600026)(4604075)(4608076)(2017052603307)(7153060); SRVR:CY4PR05MB2983; X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB2983; 3:v/7rofahXSudwHN6wqNFfB8/UVyVN4+0Exhl7cbu5OWvexQjWiwMTZCYodl72mcVIt9RZiEW2Zewtnl66958n5cUC+4gNyoNshzbZrCwiT/I7gVlW3mvQW1q1vcPBZKhJI7X8f1KS6bF7sz0tslArlPTvwPgH8/7dog8GA8PvfJNynVOlYrY5gbwrVTtQskDHP7pYtA1VAw6OF8MAO/LhmsL4UUZpIDXjpTTD/OtIsAndCp06xQQQtBbWFnbL92hXKvVi+Rth0rBiyMu4FoPePnJK0e5wLreDUlyHFLVjGtLod22L/qMtS+NrWdKrEle9k/aaBt8+NS2nTffr9rakKoLI2UJ6V+v32dfLN+DKXw=; 25:BGed8hmh9pdfGoeyOqxLwqRjbBvSZfY1gc0LvyfUA3PtLdUDymuf16w1I3BefNp7GZ8qOacqi8/oCC1UziE+QlSp1u8ZRvBrqYDKOLu5zSNStk6YuFK8Bpif2NB8lvhtYOQb9rZcfySxUqmg2FCUuiACMmWPCzcKLLtl7Jz26TemLm5lIw3vD4OHJtiFKJ8CDGtNapQy377iXgNUw4o4Kz8+Di2SJpLq+e+wYloqzzGQ2he2E5ngX22Pwk/V6H0H9PFzCTNJVei7zYU5u3aW8BS7BkUPevk3COgqLPtYKKuvOnFzU634rNOejv5CgCqWnyFh0Sl2bZva1tBWxJeZfw== X-MS-TrafficTypeDiagnostic: CY4PR05MB2983: X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB2983; 31:Cmwk2kaOaOb3xh5u+PGsblaUIp+xC0hvNMjV9MlwcLBkiPZywbDFBFH2O2jSOqu++ZMgv8tV8qMLIpUdWc1MOLejEHG10kQJ6bZwDYt8EFBcdqtWeruaahc4lNdDoHpvU8Yk5tSvK+qPEQ14Bk8u0MGMdWU3tF8Mg9bk9eEKKbmBtegVH0GB1o5fqeRpzUPgchfEnytZSb2KlM4rok91bgCxtynr74QCVWGH+CBAmsY=; 20:hNw2+xFtGWC0zNQSQssKZxnZ0/aTdGBOqMgehYqz8rOyD++BAXAvuDR5cEZd+cbRB2khv0qQcmQUbz8T4ILmQR9FFkdsStf1dpN0yttxhmCYncoDSvHxZkWTIdJMaiy2dLxzEXnT2DLAPZ8kNSzQ+L3qQSYjXJik4qvYxwGBAsIqPVYHda3e7eY/8e+2A0qBrtMeXqctwv7wUjRKhFmOL6kFbu4rOv9czz5g4hicw5gKV8t6h0sLDjMo7aZgk4GrFHqgmiXgN/YaIPZFNWFFA0yjklpco5WaOMeaoyWQWKqZ5ZhDPKGfPdjl6T4iH9PPSdxGjaMRKypbhhUiJqFIIrutlDWmXyFg2ELoMBCM4B5tVvsH+I20M9lPDsv9NA9UXOYemnU/zj10nbO8J9sMJcFAmgpav+6lX8P9be3C4LzOt3aSibF5c+0Xo9qEvDHdPNOQ0JHNMlvU1jx6sFttlWeBBPgqg1iIyZqolB9eoWGQDefPDTzSlMpceAtQ43qi X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231023)(944501075)(93006095)(93004095)(6041268)(20161123562045)(20161123564045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR05MB2983; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY4PR05MB2983; X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB2983; 4:T123D7rzU5fU5vGfN6HEci2hdxiijHFjJqcaPRq09PpNCs1n3+Kaf+HnHlqy+gaPP1vVhtlLvGGUKOiFI1oH+zLYW9bWbyTgL8QfHV139zxo3P9ENsKps/mZ0aV8iJ7b5LIjeQTSJXe5/9yaiJvIhhjkueWUZx9w0P+kVnfK+JqO750rI3FoBpnCUx7myuEMIEnWemp0XH8rSDkJYdVpwup7ki9cO/K7DEU1CH/0T8j5HPOjAoGhHauGDhBHRlOfRtVYrWRgt8YT/dJxyDZ4gg== X-Forefront-PRVS: 05514B7026 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjA1TUIyOTgzOzIzOnNFbjk0VTR6dHpINlQ3MlY3YjU4TllPSXpR?= =?utf-8?B?b2wxSFJjNHpoK0pyTHBCQnRYUmliY1dpckhHTU1nN3FSSEgvQjRybjR6WVN1?= =?utf-8?B?azc4L0kyTHFPL3NpL21DWmJDZnJXM1NTZEtRTm9Fb21xM0NqOTZSaE9VUlo4?= =?utf-8?B?a1Nlb0o0M0pmYms5d2MzSzZiYXFOMGdBQ1gwUmxhTUlQSzJ5bXE5R080Vmo1?= =?utf-8?B?K1dZSS9XajZ1SmFJL3JFQ3l3SkVVVHVseWJwS3pySWpnc1Y4dHd6MWN6di9Z?= =?utf-8?B?L1J2VFFLdTkwTkc3ZzBUeXlyVjVVVmJJOXRoSlBHVUx1ZEY1YzlZS1RZakZR?= =?utf-8?B?R3o4ZURlZ2YrUFdZa2NJTzVpcXRsb1JXbVNVWEhrYkxoTWpZaFdEczc5aGFV?= =?utf-8?B?Q0xqeEU1MkNBN1I1ZlpWOVlxdk1YZDRKL280bzBJVGVwQlFlaHE1ZURDMkds?= =?utf-8?B?R2VWMU0wWXlsSU5lUldZbi9ZWUFxemFES0l6QVd0b3FkK0IwMXJ2QXhJT3pJ?= =?utf-8?B?eEZtdHZESXdoWUM5QmIzelQ4dlA3WElsb3Jqak5PSkdtcWV5eVFSeFROMUxj?= =?utf-8?B?ZWUwUi9VbGlxM2RlalNHcHdlUEZIcmRPUVFkdjY3K0t3NG94OEt6akw4WkFL?= =?utf-8?B?UUdrSlJCNWNoU292M0thdzJwZ1NCQ0c2eUM2N2lJSWVzY0lCTU51YXI0dWFQ?= =?utf-8?B?VTJtTjIwM2s3Skw2cTFVa3B0aTFIZUxCc1k4K2pKR2I2VUYrWDVlRlowRlFZ?= =?utf-8?B?RHNLMzZkdmVLVkZzSWozbjhFSFlnalB1Y28yUkNWWWtodVUwT3BoWXQwbUEw?= =?utf-8?B?K0lJbnoyanVNVnlINzVGTXlramRJVVFtSGJld1JzUzdnNkRwKzJWODN4NkpV?= =?utf-8?B?QnI5YlRabGh6aGZnR2hJdmpBdVJTbG9iSnVlSG9aQlcyUTRpOEZzVDFJbFAv?= =?utf-8?B?LzdURVE3VmEzaHI3WXRkNGNTZ1R2YkdNNnh1NTJqOERiSFNFVlNJR1lzTC9I?= =?utf-8?B?d1phYmZPdThFbEtpbTZJVklMRTlHeFo0enZzMFY5YXNjQm1RNmtYTHg4bU5Z?= =?utf-8?B?Y0tMSjg0RDloNVhXY002U085cmlBdXBIa0JsZkJSTWR2TitDUE5YYWhVdjk2?= =?utf-8?B?UUZhU01INGpQUUxvR01abG9nb2ZDTFNOcFR2VVNQN1dtbVNPWTRaOGxKZkRh?= =?utf-8?B?MFVNTGc0bWNrQ1pMS0IyOHZhb2s1RjlYa28rOGd5bHVLU3BGZXBNSWR5Y2lF?= =?utf-8?B?SzhIRTFvbmlBNHRaVnY2V1NJazQvaUdhOFNsVFYxdTN4UllqMVE4cjZWT2NW?= =?utf-8?B?bVJoeWxkQ0RFSHFGeEtINDkzc2tESG9RVmFHRXFmSXF6aHFJTGNSTmMvelZu?= =?utf-8?B?S3hXY3RocTVrYW44TTNENEFMVkNyRjl0c3NzdjE1QTZibFhZSDhSYTU5K20y?= =?utf-8?B?bFhSeHhvT0hLTEEwL2hMdnY5Y1EwNGFYbWd0UzkzcS9JWXlPam5HR08zL1pK?= =?utf-8?B?bndZMWRxZ3gyTFNScHpWVzZDRGNFaWtvMUR1cFRhbnZhWHBnVGw0QnRUZDlD?= =?utf-8?B?VDRRQk9MSzF5TTNZY0cwbXhaY3I3dmZKTUsvY2lLdURiRFpFcmZhdEZiOXlG?= =?utf-8?B?dkFuNFp0VlZDSlBDeHl6eWw3TG5rM1I3TmlBVlFScTE0TDA5UmZzK3JtcGFn?= =?utf-8?Q?5R/uKHLADT2ab7z16+0W+n+3sCgC7VhOtKKqEsZ?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB2983; 6:9dCLoUo/9V92qFYTyO5IMsNRYOpxR8D/s4Z2kNCPeaLPzAgjwxUIw7EabQn0N4+SlTgG3NFnYMJ/+WDzkFFi+w4azAx1jay1mzzVrqYv0dBMZ3JzTNkeahWRKrNC+ny6kE7eVvQ7XJRe+EEHNwKvH8mH4R8mkUl6Ul1APmCoIazlBcXUUYhV6szR2VChA8HV1MP8Hl686au9LiL0TWGCOTTUv1OGhqEKxto8PW9hALrMCFXRahKfbv4lFS61hFSU0THz2Pi8jvmP9NSFEsH/EF52WmPuT5Is236LC81SgNeiLmSUjkXVJC2NrhBUynz0Pl01xtRZpmXaBnT+SlKmDUedJexOGh1B2NvI4DK7R8o=; 5:cyM6ygbCJUIAjpqeuhAeBZPMdhk/NL6noOkTfuetYh3gxdcye4jfNFvmRPA/XxHTTNobFvKkh7wawUaZCZG8LkOKb8XAv2Kx8CEYKQrqd/va7PR3D3oVGP5zyHw5HdJek8g7bkPL+XO4olLNtigZDPW1AOcfxGITwTQRejz3hOY=; 24:l2XDa3T6CtZPNlaEDf/68/jr97llQy+HZSHSak/3p3AxuSA/xEDwFgRfbbCco05AhzIEqSKFloygu3iqNcjNid56cKtAJPrnpDHhzyEQNzY=; 7:M3aUrTascgDI054+6NUhlNdLDuLkKeKfkNl8EjSWZ/g+vH9wrwZNlx9qBSClIuC8sGta/Mz6JLbyCBdkrWkIrDgaXgmzgfuypH/XGvsotzteUQXi5RJhRSkzGDwAk+MK19pGWWMcWS9npwDDLb+uJhrBTn7Hq5iD5RE5FeJPP8+DHbqZV+tv8yZb9jID8jIk5dTKVOZTEQZLKOL+nLt9sg7BtifExjrmTNZmWsIhCL8aO78jb4qz7WPrVfT7huXU SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB2983; 20:gjd8545rCPPosQ9Cd9k3tjgSmeu8DYNGbekvyOakuabD2dzKO69MJLaQ0k4RffluhBJ+W9ABO3JiaN+Ymj4nlTjCqrQXmSNEL1cb9M+mnIJ14Dc9H+ZH/7yu39DPoQCvK1PB76GauHSE4BAAecEnOTiqoTTUoVc4VBZQRfT3cIE= X-OriginatorOrg: ksu.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2018 17:34:38.3428 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f588e8e9-034a-4721-bcb4-08d55aabebd9 X-MS-Exchange-CrossTenant-Id: d9a2fa71-d67d-4cb6-b541-06ccaa8013fb X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d9a2fa71-d67d-4cb6-b541-06ccaa8013fb; Ip=[129.130.18.151]; Helo=[ome-vm-smtp1.campus.ksu.edu] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB2983 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 17:34:41 -0000 On Thu, Jan 11, 2018 at 6:03 AM, Eitan Adler wrote: > Hi all, > > A few years ago I fixed most of the cases where we used 1 << 31 in FreeBSD. > This expression is illegal in C. Since then the issue has arisen again. > > https://reviews.freebsd.org/D13858 fixed most of the non-contrib cases. > > I'd also like to see if we could find some more general solution, be it a > compiler warning, bit set macro, or otherwise. > For what it's worth, I've really come to like and appreciate NetBSD's approach with __BIT/__BITS. See [1] for implementation, [2] for usage. [1] http://src.illumos.org/source/xref/netbsd-src/sys/sys/cdefs.h#577 [2] http://src.illumos.org/source/xref/netbsd-src/sys/arch/arm/sunxi/sunxi_usbphy.c#L44