Date: Tue, 11 Dec 2012 20:10:33 +0400 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308655 - in head/games/xmoto: . files Message-ID: <20121211161033.GL20652@hades.panopticon> In-Reply-To: <20121211140840.GA95992@FreeBSD.org> References: <201212110314.qBB3EErH082058@svn.freebsd.org> <20121211033625.GA39028@FreeBSD.org> <20121211132128.GA50148@hades.panopticon> <20121211140840.GA95992@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Alexey Dokuchaev (danfe@FreeBSD.org) wrote: > On Tue, Dec 11, 2012 at 05:21:28PM +0400, Dmitry Marakasov wrote: > > * Alexey Dokuchaev (danfe@FreeBSD.org) wrote: > > > Looks like these two should also be mentioned in OPTIONS_DEFINE. > > > > Not adding them to OPTIONS_DEFINE preserves previous behaviour and I > > don't think NLS and DOCS should be in the OPTIONS_DEFINE ever - they are > > only meaningful to be set globally, and having them in individual ports > > More true for NLS (although traditionally most ports included it in their > OPTIONS, plus it could be desirable to set it on per-port basis because > translation can differ in quality considerably; also while I might want to > disable them for GCC or binutils, I don't mind having localized some nicely > translated desktop application or game, for example -- esp. if author's > native tongue is not English). Agreed. > Less true for DOCS, as sometimes they pull way to much stuff to build them. My opinion is that in this case a separate option should be used (e.g. DOXYGEN). That's disputable: from one POV, we'd want consistent documentation handling, from another, we won't want extra depends by default. It seems like it can be solved by setting a following policy: - DOCS which pull additional depends should be disabled by default Unfortunately, that won't really work in current situation, as DOCS are enabled by default (while no NOPORTDOCS is set). > While I might generally want them, for some ports I prefer to have it > optional with definitive description of what to expect (e.g. when it pulls > TeX or ghostscript). > > That said, I am worried that we don't seem to have these issues documented > thoroughly in PH. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121211161033.GL20652>