From owner-freebsd-virtualization@FreeBSD.ORG  Wed Oct 29 01:01:21 2014
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D1221278
 for <freebsd-virtualization@freebsd.org>; Wed, 29 Oct 2014 01:01:21 +0000 (UTC)
Received: from mail-vc0-x229.google.com (mail-vc0-x229.google.com
 [IPv6:2607:f8b0:400c:c03::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8F194216
 for <freebsd-virtualization@freebsd.org>; Wed, 29 Oct 2014 01:01:21 +0000 (UTC)
Received: by mail-vc0-f169.google.com with SMTP id hy4so924073vcb.0
 for <freebsd-virtualization@freebsd.org>; Tue, 28 Oct 2014 18:01:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=WAaVLxbiMPjHtSNXexvdb0of/rF+9Nz/5GH8oBN8Vp4=;
 b=ZQzt04RMEZQ8XwTNMrTaQZhAloydPVeH+Za8UsmmYqTvd/mMg7HWE1mwZopiJmBvvc
 98IEcJpBLBJs4eogxtdS+CUeuZvH6gCjK/PM7w+LO48+pNffj0RHKE053C8qJ5dTes8X
 eTxVO9em5mSWH5NlvUCm7U+x49ddYC5dWKxw4E9jtj8HlIgeXj476akfLVj2BW3od3wR
 HOZy1UVBWIdyWaOeNFqDPEFc0rjp3ApQgRueg60wxV03A0T+lawvuQpvhtUlh5fnMxVe
 3tV6oh9v8Dft0hKRPzewmY+EBpvpo8w2s5DKw2VZirrqnXw7mfJWpleZqayZwAPPmHd9
 WUbg==
MIME-Version: 1.0
X-Received: by 10.52.129.230 with SMTP id nz6mr620616vdb.67.1414544480442;
 Tue, 28 Oct 2014 18:01:20 -0700 (PDT)
Received: by 10.220.150.68 with HTTP; Tue, 28 Oct 2014 18:01:20 -0700 (PDT)
In-Reply-To: <54503292.9040907@redhat.com>
References: <1414094284-29055-1-git-send-email-cse.cem@gmail.com>
 <1414094284-29055-2-git-send-email-cse.cem@gmail.com>
 <54503292.9040907@redhat.com>
Date: Tue, 28 Oct 2014 21:01:20 -0400
Message-ID: <CAG6CVpWSGcHR2jU7zCsm8OP584dR2Pt7WHOV5KyQUy9Lpq+8tg@mail.gmail.com>
Subject: Re: [libvirt] [PATCH 1/2] bhyve: Support /domain/bootloader
 configuration for non-FreeBSD guests.
From: Conrad Meyer <cse.cem@gmail.com>
To: Michal Privoznik <mprivozn@redhat.com>
Content-Type: text/plain; charset=UTF-8
Cc: libvir-list@redhat.com,
 "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org>
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
 <freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization/>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Oct 2014 01:01:21 -0000

> I don't think it's safe to pass arbitrary arguments from XML. I find this
> too critical to ACK the patch, buy maybe further discussion can change my
> mind.

Michal,

You're reviewing a 4-revision old version of this patch, see v5 for
the most recent set. However, this bit is still present in v5. What is
<bootloader_args> in the XML is for, if not arbitrary arguments?


Thanks,
Conrad