From owner-freebsd-hackers Sat Sep 13 23:22:04 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id XAA24535 for hackers-outgoing; Sat, 13 Sep 1997 23:22:04 -0700 (PDT) Received: from freebie.lemis.com (gregl1.lnk.telstra.net [139.130.136.133]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id XAA24521 for ; Sat, 13 Sep 1997 23:21:59 -0700 (PDT) Received: (from grog@localhost) by freebie.lemis.com (8.8.7/8.8.5) id PAA15239; Sun, 14 Sep 1997 15:51:51 +0930 (CST) Message-ID: <19970914155151.53488@lemis.com> Date: Sun, 14 Sep 1997 15:51:51 +0930 From: Greg Lehey To: Mike Smith Cc: Terry Lambert , brian@awfulhak.org, freebsd-hackers@FreeBSD.ORG Subject: Re: rc & rc.conf References: <19970914151517.24823@lemis.com> <199709140609.PAA00821@word.smith.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.81e In-Reply-To: <199709140609.PAA00821@word.smith.net.au>; from Mike Smith on Sun, Sep 14, 1997 at 03:39:51PM +0930 Organisation: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8250 Fax: +61-8-8388-8250 Mobile: +61-41-739-7062 WWW-Home-Page: http://www.lemis.com/~grog Fight-Spam-Now: http://www.cauce.org Sender: owner-freebsd-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, Sep 14, 1997 at 03:39:51PM +0930, Mike Smith wrote: >> >> Yes, I'm not quite *that* stupid. We have two variables here: a >> -flags which is set with the flags, and an -enable which is set to >> either YES or NO. The original logic says "don't do it unless -enable >> is YES". Brian's saying "do it unless -enable is NO". I don't see an >> advantage in doing it this way, and I certainly don't see a disaster >> waiting to happen in the old way. > > The advantages are combined; consistency with all of the other similar > options, and by using "not NO", the _enable and _flags variables may > subsequently be combined. Well, sure, but he didn't do that. And that's the way it used to be with other flags, so somebody has deliberately specified an '-enable' and a '-flags' instead of combining them as a predicate. While checking this out, however, I came across the real reason: revision 1.129 date: 1997/06/18 16:01:18; author: pst; state: Exp; lines: +8 -3 Add cron_enable and inetd_enable flags to rc.conf. WARNING: don't update rc and forget to update rc.conf, or you won't be able to telnet back into your box after a reboot. Now I understand. But I don't think I agree. Greg