From nobody Mon Feb 24 18:17:05 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z1pq62fjDz5pcd8; Mon, 24 Feb 2025 18:17:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z1pq61qzcz3G7L; Mon, 24 Feb 2025 18:17:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740421026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=y8WYG52VaxGiY3n5gJa9ZhIX7b+zvLsoC7ZRM6d7X6s=; b=GONlLNAhPckmiVW2lOeQueYlmnCxndIzsAKRs66yzXFLfE4QMbP0LR0EmA7VKRxM8LTu3+ U35PczfSmGQra8j+nDJl9iWoe8bz+akyNbCpIP/nIHHMJT1aG+OOuAGcH2m2gubLjh+s8F khd5faOKXZbWaSRlfa5pKoljwErPEONxxBmwtD8dnVfBTx9KvrBUkprzmjfdipKvxlUINe 9ELZNDuBnUDQHb5iF0dghzMXUdBn2RAkOCVXJNSti8rwXmUsM1GBgvypCjQeyCrHAz2bHa h8nh0UPBluRwELhIwtQ8nzx4MCSK3cJ/uwe0Q1qVX/A9CqB4zEmnMzSLFN5kAQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740421026; a=rsa-sha256; cv=none; b=DSDvHkmQhLIo3+2afvPsjwxF9f5rkIqq7DWurMCKLlpkomjoWw72pISRReQYoQ3Gj9/W8+ POSr/CWl6X5JbyVmtJkMlFukF7vVKaC3y6nk1mEwjStmWnOhfYBDYi9uCfuQ8YA57CSfBg jBiQwpnqMozjUTIrUOpaib+/yvIfhmg0qD7hgU1jHHlYEU9yMmhXZHzEeMo5KwJTQLZa7H Jlo7W5Vvb0kX55CosQymNfLbyvO8uGwpZEH04dzp19rr/O8mN+QQEMBSWSpJrMhNsX/WH6 IMbKgHD5u1+DznU3R4VF+xI8xK+9IIz97EDfZ3cU9THXcwuHzSQ3bNMtuuapPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740421026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=y8WYG52VaxGiY3n5gJa9ZhIX7b+zvLsoC7ZRM6d7X6s=; b=GRff5VwJHvf3ANFkWH71skL2BDIGrK7Oaj41puEoUOIah08L/4onBwfAlYw6bFDy2cyrjW sfCOHjtPutcOBJuW+HcxUPz+Tp/xmfh4VUqnMvupKIxEbxt4t4WJibIVyHN1f92JDi+8kx r0Z6/wAEW/xltMhcIOrho3/2ruIIHc2ABIRlfCvjDNQGr0+RCIfLOv5Y7oxhB5P6E7oNBz snEL8Dz6iNMq+bcxMc7LnSwXvAChJfHo3H7eCu59w6Trezc7XhWgczy19pZhDoOZAzg8N/ gEca/LrQJ1A0EVboT/dgo3cOK3ueUnu9E5+vWEPA56SbIEsAH7YH3iqlR+BF5w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z1pq60scLzrwd; Mon, 24 Feb 2025 18:17:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51OIH56e084717; Mon, 24 Feb 2025 18:17:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51OIH5Ee084714; Mon, 24 Feb 2025 18:17:05 GMT (envelope-from git) Date: Mon, 24 Feb 2025 18:17:05 GMT Message-Id: <202502241817.51OIH5Ee084714@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 0932ae6b9977 - stable/14 - lpd: Tighten permissions on /var/run/printer List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0932ae6b99779a4da1c8032f6622e46750786181 Auto-Submitted: auto-generated The branch stable/14 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=0932ae6b99779a4da1c8032f6622e46750786181 commit 0932ae6b99779a4da1c8032f6622e46750786181 Author: Stanislav Shalunov AuthorDate: 2024-10-11 15:49:02 +0000 Commit: Ed Maste CommitDate: 2025-02-24 18:11:34 +0000 lpd: Tighten permissions on /var/run/printer Exclude group read/write permissions as well. Otherwise, group wheel can submit things w/o the normal accounting. While group wheel is generally trusted on the machine, submitting jobs w/o checks is not one of the functions we document for that group. PR: 17289 Differential Revision: https://reviews.freebsd.org/D47040 (cherry picked from commit 6cde8f3ef7cd060be39d78055eaf982b06b19a3b) --- usr.sbin/lpr/lpd/lpd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/lpr/lpd/lpd.c b/usr.sbin/lpr/lpd/lpd.c index 19456c9406df..c9a7e1615b74 100644 --- a/usr.sbin/lpr/lpd/lpd.c +++ b/usr.sbin/lpr/lpd/lpd.c @@ -326,7 +326,7 @@ main(int argc, char **argv) sigaddset(&nmask, SIGTERM); sigprocmask(SIG_BLOCK, &nmask, &omask); - (void) umask(07); + (void) umask(077); signal(SIGHUP, mcleanup); signal(SIGINT, mcleanup); signal(SIGQUIT, mcleanup);