Date: Mon, 31 Aug 2020 19:28:57 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Yuri Victorovich <yuri@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r547197 - head/math/faiss Message-ID: <20200831172857.GA2367@PinebookPro> In-Reply-To: <202008311609.07VG93Tr035345@repo.freebsd.org> References: <202008311609.07VG93Tr035345@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline This commit is wrong. 1. openblas works also on powerpc and powerpc64 - probably others as well. 2. On architectures where openblas doesn't build, this port will not even start building to due missing dependency, so setting ONLY_FOR_ARCHS is pointless. If you insist on setting ONLY_FOR_ARCHS, could you at least take a list of architectures where openblas builds from https://www.freshports.org/math/openblas and set it properly? On 20-08-31 16:09:03, Yuri Victorovich wrote: >Author: yuri >Date: Mon Aug 31 16:09:03 2020 >New Revision: 547197 >URL: https://svnweb.freebsd.org/changeset/ports/547197 > >Log: > math/faiss: Add ONLY_FOR_ARCHS > > Reported by: linimon > >Modified: > head/math/faiss/Makefile > >Modified: head/math/faiss/Makefile >============================================================================== >--- head/math/faiss/Makefile Mon Aug 31 16:01:10 2020 (r547196) >+++ head/math/faiss/Makefile Mon Aug 31 16:09:03 2020 (r547197) >@@ -12,6 +12,9 @@ COMMENT= Library for efficient similarity search & clu > LICENSE= MIT > LICENSE_FILE= ${WRKSRC}/LICENSE > >+ONLY_FOR_ARCHS= amd64 i386 >+ONLY_FOR_ARCHS_REASON= Links with libopenblasp-rN.N.N.so which is installed by math/openblas only on amd64,i386 architectures >+ > LIB_DEPENDS= libopenblasp-r0.3.9.so:math/openblas > > USES= cmake compiler:c++11-lang --mP3DRpeJDSE+ciuQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl9NM1kwFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydIPEP/RjT9+pocj6ZFuZuZbn7jx5iUQN4zDkmNuhX5d766wFtnUy+Rp6IhfVL j+O+Vv6JvCp8c3u6+77enRSRZJyRGpllSU6DlNajdDGO4VRjYaIk9TguKBQDI8Db 1XFXa9cJTh7I8qS6by/71LMM2Uq/hvU9/+GVf0ckj2nmy+t4KsOkjYa5sd+heX5t eQm7u+wRpz6h8pEkGlQUpdkuxQt5b7iNj6eaMgPDlAvHz1qD+JdsvO3xwuGOqcUm rvlNtBgeypCVEzT/Ift5XEDmpPLU90PsAe2bHM+HAT1GVeBZZIY75LMyUW8MdKoV UO+hsxUmbpbdL+/Mz0Ft9CbdIJ5iJg8xU+4l/rWeRggPqWtv0nXOiZN9kNGWGMMa vLAIza+/DlfAEDG+7Dn/4UqNqOO1ydWtlG954jLKx5DvkmDV305vVodCqTAUf5PB XbAJ3SV+ofNtlg3qYKffQN5LpBXyBKL6iXNQ8LCiKsNeNO2QNLQIzv3siDc89nha fdW15SbRzhTxvcWvOUequBRvpktuMf1Y0aYWU4SBiTGr9Xx0rkQ75ZM2JdFgSYpu 8536MrhDH7YwxHGExIEbHt7Py625U2SPr7moJYHnGephTM6fX9taz79p+hcj5Qg8 EpO16V1hYQYcdjsip1kc5sO59lRsQ/9gj0E+iP/sf9Owcz0tYTN6 =ogjl -----END PGP SIGNATURE----- --mP3DRpeJDSE+ciuQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200831172857.GA2367>