From owner-cvs-all Fri Jul 27 20:40:45 2001 Delivered-To: cvs-all@freebsd.org Received: from obsecurity.dyndns.org (adsl-64-169-104-149.dsl.lsan03.pacbell.net [64.169.104.149]) by hub.freebsd.org (Postfix) with ESMTP id 0A93337B405; Fri, 27 Jul 2001 20:40:39 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 0A3A366B25; Fri, 27 Jul 2001 20:40:37 -0700 (PDT) Date: Fri, 27 Jul 2001 20:40:37 -0700 From: Kris Kennaway To: "David E. O'Brien" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c src/usr.sbin/pkg_install/lib str.c Message-ID: <20010727204037.A58795@xor.obsecurity.org> References: <200107280159.f6S1xw810069@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="2fHTh5uZTiUOsy+g" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200107280159.f6S1xw810069@freefall.freebsd.org>; from obrien@FreeBSD.org on Fri, Jul 27, 2001 at 06:59:58PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 27, 2001 at 06:59:58PM -0700, David E. O'Brien wrote: > obrien 2001/07/27 18:59:58 PDT >=20 > Modified files: > usr.sbin/pkg_install/add main.c=20 > usr.sbin/pkg_install/lib str.c=20 > Log: > Remove s_strl*(). I am not sure what was thought they accomplished. Grr. Thanks for discussing this with me (the person who added s_strl*). I'm not happy with this commit: I don't like endless amounts of inline code duplication when a simple function can do the job. Please back this out until we can come to an agreement. Kris --2fHTh5uZTiUOsy+g Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7YjQ0Wry0BWjoQKURApGbAJ48kraPsOvY+1Tpt+rBJlex2TnzowCfTT/7 gs7mDqYf4beFGc6QI3cQovQ= =jvE9 -----END PGP SIGNATURE----- --2fHTh5uZTiUOsy+g-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message