From owner-cvs-all@FreeBSD.ORG Fri Mar 7 15:56:20 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A10D106566B; Fri, 7 Mar 2008 15:56:20 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.78]) by mx1.freebsd.org (Postfix) with ESMTP id 4C89F8FC17; Fri, 7 Mar 2008 15:56:20 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from mac.com (asmtp007-s [10.150.69.70]) by smtpoutm.mac.com (Xserve/smtpout015/MantshX 4.0) with ESMTP id m27FuKGv010225; Fri, 7 Mar 2008 07:56:20 -0800 (PST) Received: from [192.168.1.100] (209-128-86-226.bayarea.net [209.128.86.226]) (authenticated bits=0) by mac.com (Xserve/asmtp007/MantshX 4.0) with ESMTP id m27FuHtj021027 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 7 Mar 2008 07:56:17 -0800 (PST) Message-Id: <17C624F8-3233-49E6-8235-30F8B06C6513@mac.com> From: Marcel Moolenaar To: John Baldwin In-Reply-To: <200803070801.30460.jhb@freebsd.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Date: Fri, 7 Mar 2008 07:56:10 -0800 References: <200803061724.m26HOSPO026401@repoman.freebsd.org> <200803070801.30460.jhb@freebsd.org> X-Mailer: Apple Mail (2.919.2) Cc: cvs-src@freebsd.org, Marcel Moolenaar , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys pcpu.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 15:56:20 -0000 On Mar 7, 2008, at 5:01 AM, John Baldwin wrote: > On Thursday 06 March 2008 12:24:28 pm Marcel Moolenaar wrote: >> marcel 2008-03-06 17:24:28 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/sys pcpu.h >> Log: >> Move the PCPU_MD_FIELDS last in struct pcpu. While this header is >> private to the kernel, some ports define _KERNEL and include this >> header. While arguably this is wrong, it's also reality. By having >> the MD fields last, architectures that have CPU-specific variations >> of PCPU_MD_FIELDS will at least have the MI fields at a constant >> offset. Of course, having all MI fields first helps kernel >> debugging >> as well, so this is not a change without some benefits to us. >> >> This change does not result in an ABI breakage, because this header >> is not part of the ABI. Recompilation of lsof is required though :-) > > It actually started out being the last "field" in the structure but > some new > fields were incorrectly added after it rather than before it. It > might > warrant a comment to prevent similar regressions in the future. > > -- > John Baldwin -- Marcel Moolenaar xcllnt@mac.com