From owner-cvs-all Sat Jan 19 8:36:57 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 35F6337B400; Sat, 19 Jan 2002 08:36:50 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g0JGame11179; Sat, 19 Jan 2002 19:36:48 +0300 (MSK) (envelope-from ache) Date: Sat, 19 Jan 2002 19:36:48 +0300 From: "Andrey A. Chernov" To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/ftpd ftpd.c Message-ID: <20020119163648.GD10976@nagual.pp.ru> References: <200201190901.g0J91H641020@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.24i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Jan 19, 2002 at 17:08:55 +0100, Dag-Erling Smorgrav wrote: > "Andrey A. Chernov" writes: > > Log: > > Add PAM_CRED_ERR as valid failure case > > It's not. Only pam_setcred() is allowed to return PAM_CRED_ERR. > > None of your patches to pam_opie, pam_unix or ftpd were reviewed by > anyone with in-depth knowledge of PAM. I'd like you to back them all > out and submit them to markm and myself for review, along with a > *detailed* explanation of what you think is wrong and why you think > your patch is correct. 1) I agree that PAM_CRED_ERR may be not the perfect choice and hear for better altenatives. 2) Excepting that thing, you already see my patches in the tree. I may produce diff, if it is needed. 3) I already post most detailed explanation considering all possible variants. I can resend it to you, if you miss it in the thread. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message