From owner-freebsd-net@FreeBSD.ORG Tue Oct 1 00:28:29 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 892543B0 for ; Tue, 1 Oct 2013 00:28:29 +0000 (UTC) (envelope-from syuu@dokukino.com) Received: from mail-ie0-x22c.google.com (mail-ie0-x22c.google.com [IPv6:2607:f8b0:4001:c03::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5417B2F5F for ; Tue, 1 Oct 2013 00:28:29 +0000 (UTC) Received: by mail-ie0-f172.google.com with SMTP id x13so12070715ief.17 for ; Mon, 30 Sep 2013 17:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dokukino.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=1WWSagWCabKdQwcrnQEmQIriNavt8J4qMQmKvx9ft08=; b=EI+Bz3me4dVYFxgGy+kgd6YkROHGhsSuDKuXUjAl1cEaqYTvnYxID1/Dx1B40k7qzb CCUfokaME1BTdk+TMjhK/AIaPPyU1rFAa87pjeIFuTfXPwebRPrb3CwSGz/BObe/kQeG Wm+kP5TXpsCWyl8wqbpO7ak0CggnAFBRAh1Dg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=1WWSagWCabKdQwcrnQEmQIriNavt8J4qMQmKvx9ft08=; b=Gnbd15wLFjSD0vIbmjLUfmVMx9iJMLwd7QLM7SXo90cTmvubWWHJteWGQPPOxIygPx PLbFb3m0jjjFRzLFseG+EbUoQsN/jq18o2Xr/zbxAhB6krzpsQ9rM8alZFhoGjk8Tkfb hOmLMXd9HWbVnFKeZnYtlAntVR06N6UnBiOU+EWkWXCpYyggvbXHNCQg/fqhknvX0Zpk SffhsehZZFabzsGiyBKayEGLk+W7X+5VE0rMqT3qAD5u9ZHgSpsEw1OOXcCApcWMbusi HjqPQ//in2KCjZqdrTCDNz0Zf5YnjTKSZe7CdfNGKIqDdHJjVSVBa2AwLBEv3xo3G9qz dP1Q== X-Gm-Message-State: ALoCoQm718YY6KxxH2LvZs2scvEmorJGmdl8dgaUWqA9ul2Kg1DdlTR9xaCV1Q05P2VvMlcxMpNV X-Received: by 10.50.238.196 with SMTP id vm4mr16014707igc.43.1380587308757; Mon, 30 Sep 2013 17:28:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.235.240 with HTTP; Mon, 30 Sep 2013 17:27:48 -0700 (PDT) In-Reply-To: References: From: Takuya ASADA Date: Tue, 1 Oct 2013 09:27:48 +0900 Message-ID: Subject: Re: Flow Director statistics for ixgbe(4) To: hiren panchasara Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: FreeBSD Net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Oct 2013 00:28:29 -0000 2013/10/1 hiren panchasara > > > > On Mon, Sep 30, 2013 at 1:48 PM, Takuya ASADA wrote: > >> Hi, >> >> descriptions are added. >> > > Great. > > My minor suggestions (you can ignore them :-)) > > from > "Number of filters addition events that do not change the number of free" > to > "Number of failed filter addition events" > > (I believe, "do not change the number of free" part is given when addition > is failing) > The specification says: Number of filters addition events that do not change the number of free (non programmed) filters in the flow director filters logic (FDIRFREE.FREE). These events can be either filters update, filters collision, or tentative of filter additions when there is no sufficient space remaining in the filter table. The counter is stacked at 0xFF and cleared on read. So it's not just failing addition, but also update(filter already exists && filter update succeeded), filter collision, and no space to add filter(add failing). I haven't good idea to describe this.. > from > "Number of packets that missed matched any flow director filter" > to > "Number of packets that didn't match any flow director filter" > > >> >> 2013/10/1 hiren panchasara >> >>> >>> >>> >>> On Mon, Sep 30, 2013 at 12:02 PM, Takuya ASADA wrote: >>> >>>> Hi, >>>> >>>> This is originally part of "ixgbetool" patch, but I think it can be >>>> discuss >>>> separately: >>>> >>>> http://freebsd.1045724.n5.nabble.com/Adding-Flow-Director-sysctls-to-ixgbe-4-was-netmap-traffic-distribution-tp5847066p5847789.html >>>> >>>> I implemented sysctls to expose Flow Director statistics. >>>> It works like this: >>>> $ sysctl dev.ix.0.mac_stats|grep fdir >>>> dev.ix.0.mac_stats.fdirfree_free: 8192 >>>> dev.ix.0.mac_stats.fdirfree_coll: 0 >>>> dev.ix.0.mac_stats.fdirustat_add: 0 >>>> dev.ix.0.mac_stats.fdirustat_remove: 0 >>>> dev.ix.0.mac_stats.fdirfstat_fadd: 0 >>>> dev.ix.0.mac_stats.fdirfstat_fremove: 0 >>>> dev.ix.0.mac_stats.fdirmatch: 0 >>>> dev.ix.0.mac_stats.fdirmiss: 23 >>>> >>> >>> I am running this with the ixgbetool patch you have and only 1 issue >>> I've seen so far: fdirustat_add increments on adding a filter but >>> fdirustat_remove does not on deleting one (if thats how its supposed to >>> work) >>> >> > As we talked on another thread, yes, problem is just the counter not > getting updated. The functionality is fine. > > > Appreciate your awesome work. > > Cheers, > Hiren > >