From nobody Fri Jun 11 13:49:04 2021 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0C5B35D6B27 for ; Fri, 11 Jun 2021 13:49:05 +0000 (UTC) (envelope-from mgrooms@shrew.net) Received: from mx2.shrew.net (mx2.shrew.net [38.97.5.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4G1hym1xw9z3GlC for ; Fri, 11 Jun 2021 13:49:04 +0000 (UTC) (envelope-from mgrooms@shrew.net) Received: from mail.shrew.net (mail.shrew.prv [10.24.10.20]) by mx2.shrew.net (8.15.2/8.15.2) with ESMTP id 15BDn224027623 for ; Fri, 11 Jun 2021 08:49:02 -0500 (CDT) (envelope-from mgrooms@shrew.net) Received: from [10.22.200.30] (unknown [136.49.68.36]) by mail.shrew.net (Postfix) with ESMTPSA id DC4DF199AA9 for ; Fri, 11 Jun 2021 08:48:57 -0500 (CDT) Subject: Re: Easily reproducible stable/13 kernel crash To: freebsd-arm@freebsd.org References: <63c37775-f1f6-def7-1ca2-4ac0460c46e2@shrew.net> <87y2bhuehz.wl-herbert@gojira.at> <87wnr0vq79.wl-herbert@gojira.at> <6d268f28-373e-fd84-9fe8-9e39831760e5@selasky.org> <87tum48ror.wl-herbert@gojira.at> <770ec82a-5fa5-530c-b059-bcae09c213e1@selasky.org> <6539d48b-499c-b27b-f4aa-1af339bb5bc8@selasky.org> From: Matthew Grooms Message-ID: Date: Fri, 11 Jun 2021 08:49:04 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org MIME-Version: 1.0 In-Reply-To: <6539d48b-499c-b27b-f4aa-1af339bb5bc8@selasky.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx2.shrew.net [10.24.10.11]); Fri, 11 Jun 2021 08:49:02 -0500 (CDT) X-Rspamd-Queue-Id: 4G1hym1xw9z3GlC X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mgrooms@shrew.net designates 38.97.5.132 as permitted sender) smtp.mailfrom=mgrooms@shrew.net X-Spamd-Result: default: False [-3.30 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[38.97.5.132:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arm@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[38.97.5.132:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[shrew.net]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:174, ipnet:38.0.0.0/8, country:US]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[freebsd-arm]; RECEIVED_SPAMHAUS_PBL(0.00)[136.49.68.36:received] X-ThisMailContainsUnwantedMimeParts: N On 6/11/2021 8:40 AM, Hans Petter Selasky wrote: > Hi, > > Also need to update tcp_var.h: > > diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c > index dff7767cd9c..33bc0549165 100644 > --- a/sys/netinet/tcp_subr.c > +++ b/sys/netinet/tcp_subr.c > @@ -1234,6 +1234,10 @@ tcp_init(void) >         tcp_inp_lro_wokeup_queue = counter_u64_alloc(M_WAITOK); >         tcp_inp_lro_compressed = counter_u64_alloc(M_WAITOK); >         tcp_inp_lro_locks_taken = counter_u64_alloc(M_WAITOK); > +       tcp_extra_mbuf = counter_u64_alloc(M_WAITOK); > +       tcp_would_have_but = counter_u64_alloc(M_WAITOK); > +       tcp_comp_total = counter_u64_alloc(M_WAITOK); > +       tcp_uncomp_total = counter_u64_alloc(M_WAITOK); >  #ifdef TCPPCAP >         tcp_pcap_init(); >  #endif > diff --git a/sys/netinet/tcp_var.h b/sys/netinet/tcp_var.h > index c9b337b3c3d..049aa0cc7b0 100644 > --- a/sys/netinet/tcp_var.h > +++ b/sys/netinet/tcp_var.h > @@ -984,6 +984,10 @@ extern counter_u64_t tcp_inp_lro_direct_queue; >  extern counter_u64_t tcp_inp_lro_wokeup_queue; >  extern counter_u64_t tcp_inp_lro_compressed; >  extern counter_u64_t tcp_inp_lro_locks_taken; > +extern counter_u64_t tcp_extra_mbuf; > +extern counter_u64_t tcp_would_have_but; > +extern counter_u64_t tcp_comp_total; > +extern counter_u64_t tcp_uncomp_total; > >  #ifdef NETFLIX_EXP_DETECTION >  /* Various SACK attack thresholds */ > This patch fixes the crash for me. A sysctl -a now completes without an issue. Thanks for the fast response! -Matthew