From owner-freebsd-current@FreeBSD.ORG Sun Mar 21 15:44:42 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3A7716A4CE; Sun, 21 Mar 2004 15:44:42 -0800 (PST) Received: from orange.csi.cam.ac.uk (orange.csi.cam.ac.uk [131.111.8.77]) by mx1.FreeBSD.org (Postfix) with ESMTP id 16D1043D1D; Sun, 21 Mar 2004 15:44:42 -0800 (PST) (envelope-from br260@cam.ac.uk) Received: from br260.wolfson.cam.ac.uk ([131.111.242.109] helo=[192.168.0.2]) by orange.csi.cam.ac.uk with esmtp (Exim 4.12) id 1B5CcT-0006oV-00; Sun, 21 Mar 2004 23:44:41 +0000 In-Reply-To: <20040321154513.Q30715@pooker.samsco.home> References: <20040321154513.Q30715@pooker.samsco.home> Mime-Version: 1.0 (Apple Message framework v613) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Bin Ren Date: Sun, 21 Mar 2004 23:44:37 +0000 To: Scott Long X-Mailer: Apple Mail (2.613) cc: Current FreeBSD Subject: Re: Who can commit this.. kse vs ULE X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Mar 2004 23:44:42 -0000 explained here: http://docs.freebsd.org/cgi/mid.cgi?20040213063139.71298ea9.taku -- Bin On 21 Mar 2004, at 22:46, Scott Long wrote: > > This is a qualitative statement. What exactly is the problem, on a > technical level? > > Scott > > On Sun, 21 Mar 2004, Julian Elischer wrote: > >> ULE makes KSE threaded processes slow, unresposive and soemtimes >> unusably so. >> >> On Sun, 21 Mar 2004, Scott Long wrote: >> >>> Thanks. What is the problem that is referred to in the email? This >>> patch looks to be a hack. >>> >>> Scott >>> >>> Julian Elischer wrote: >>>> Scott here's the patch I mentioned... >>>> ---------- Forwarded message ---------- >>>> Date: Wed, 17 Mar 2004 18:30:45 -0800 >>>> From: David O'Brien >>>> To: Taku YAMAMOTO >>>> Cc: freebsd-current@freebsd.org >>>> Subject: Re: [PATCH] for SCHED_ULE & libpthread issue (was Re: I >>>> like >>>> >>>> SCHED_4BSD) >>>> >>>> On Fri, Mar 12, 2004 at 09:23:47AM +0900, Taku YAMAMOTO wrote: >>>> >>>>> Until the problem is fully addressed, I will propose following >>>>> patch >>>>> to be applied. (the least intrusive one attached in the former >>>>> message) >>>> >>>> >>>> Do people think we should commit this? >>>> >>>> --- sched_ule.c.orig Fri Feb 13 05:24:48 2004 >>>> +++ sched_ule.c Fri Feb 13 05:37:53 2004 >>>> @@ -186,7 +186,7 @@ >>>> #define SCHED_INTERACTIVE(kg) \ >>>> (sched_interact_score(kg) < SCHED_INTERACT_THRESH) >>>> #define SCHED_CURR(kg, ke) \ >>>> - (ke->ke_thread->td_priority != kg->kg_user_pri || \ >>>> + (ke->ke_thread->td_priority < kg->kg_user_pri || \ >>>> SCHED_INTERACTIVE(kg)) >>>> >>>> /* >>>> @@ -1166,11 +1166,8 @@ >>>> */ >>>> if ((ke->ke_flags & KEF_ASSIGNED) == 0) { >>>> if (TD_IS_RUNNING(td)) { >>>> - if (td->td_proc->p_flag & P_SA) { >>>> - kseq_load_rem(KSEQ_CPU(ke->ke_cpu), ke); >>>> - setrunqueue(td); >>>> - } else >>>> - kseq_runq_add(KSEQ_SELF(), ke); >>>> + kseq_load_rem(KSEQ_CPU(ke->ke_cpu), ke); >>>> + setrunqueue(td); >>>> _______________________________________________ >>>> freebsd-current@freebsd.org mailing list >>>> http://lists.freebsd.org/mailman/listinfo/freebsd-current >>>> To unsubscribe, send any mail to >>>> "freebsd-current-unsubscribe@freebsd.org" >>>> >>>> >>> >>> >>> >> >> >> > _______________________________________________ > freebsd-threads@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-threads > To unsubscribe, send any mail to > "freebsd-threads-unsubscribe@freebsd.org" >