From owner-svn-src-head@freebsd.org Sat Nov 10 08:18:41 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE10A112C98A for ; Sat, 10 Nov 2018 08:18:41 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yw1-xc2e.google.com (mail-yw1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BEA987F3E1 for ; Sat, 10 Nov 2018 08:18:40 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yw1-xc2e.google.com with SMTP id p18-v6so2527775ywg.12 for ; Sat, 10 Nov 2018 00:18:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ft+zNFwmeu7u8Qxx+QKlyz82Qf3SRb+WnRBxsDwsetc=; b=bH8VvnzSar5aX56USYZbvKwdJPv54PeGBDpActfdRU8nNoiFrc0650KlwwLOjlVpMk 01SUDfkD939EVKa8ytxC3+Cy552qfGBfKSHhGlKISgRVpp9JKTgV2P7YUNYNXw3tGrL5 O4caH5YqKswd5S007DfOPvcwoK/hcqbjpKs/4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ft+zNFwmeu7u8Qxx+QKlyz82Qf3SRb+WnRBxsDwsetc=; b=aENDawxwRb0KKoMNTzeq43ysT52iS4FfxtqiVVCAzlEuLEq4U4oz9YrWlE6+7cC1mS AHK4SsKZDfYHB48FDbdD/cJRIZi3uPVrtGWUTROiVUtiBofkag5ujOuGNTH1wgbVx1ln IDUyCPRlzvS4koRxAul1Py+6vF1ZmzNHnbH9v3oH7qI2NiHOkSPOjYtDtGpkyIoLdI94 BCYY+ZdJwn86sqpf4baweIyX9wpxKM0bHw/upSkai2uk2+lbdWOtszCpVhly+VJvKDVD OFGziPqMkgCtwMXHNf7pMdUzJx1yQbOfZq3nm0dAkEzSmtgRZvi7iHAgmI3X9ksVrfCM V6cQ== X-Gm-Message-State: AGRZ1gJ3aUhyMwOaCdoUVQdclLZ/oHziMM5ZuBhbvEsjZBhlLN6aKV7D Hd2KmMFIscaz9TvjXTPMAefhw/Ri6ICgimUJ6hDPVw== X-Google-Smtp-Source: AJdET5dNSzKdw0wzkbc9+dfUIZribV4TrLlhL593plwo5dmT5BHC5RnA8XMCy80SQYuWv/TzqEIoBy6x821Pq6SmCus= X-Received: by 2002:a81:7257:: with SMTP id n84-v6mr11710488ywc.277.1541837919726; Sat, 10 Nov 2018 00:18:39 -0800 (PST) MIME-Version: 1.0 References: <201811091803.wA9I31ie014903@repo.freebsd.org> <20181109181901.GA61841@spindle.one-eyed-alien.net> In-Reply-To: <20181109181901.GA61841@spindle.one-eyed-alien.net> From: Eitan Adler Date: Sat, 10 Nov 2018 00:18:13 -0800 Message-ID: Subject: Re: svn commit: r340294 - head/sys/compat/freebsd32 To: Brooks Davis Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: BEA987F3E1 X-Spamd-Result: default: False [-4.42 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[eitanadler.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[eitanadler.com]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[eitanadler.com:+]; MX_GOOD(-0.01)[ASPMX2.GOOGLEMAIL.com,ALT2.ASPMX.L.GOOGLE.com,ASPMX.L.GOOGLE.com,ALT1.ASPMX.L.GOOGLE.com,ASPMX3.GOOGLEMAIL.com]; RCVD_IN_DNSWL_NONE(0.00)[e.2.c.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.92)[-0.925,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.99)[ipnet: 2607:f8b0::/32(-2.92), asn: 15169(-1.92), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2018 08:18:42 -0000 On Fri, 9 Nov 2018 at 10:19, Brooks Davis wrote: > > On Fri, Nov 09, 2018 at 06:03:01PM +0000, Brooks Davis wrote: > > Author: brooks > > Date: Fri Nov 9 18:03:01 2018 > > New Revision: 340294 > > URL: https://svnweb.freebsd.org/changeset/base/340294 > > > > Log: > > Fix a number of bugs in freebsd32's capabilities.conf. > > > > Bugs range from failure to update after changing syscall implementaion > > names to using the wrong name. Somewhat confusingly, the name in > > capabilities.conf is exactly the string that appears in syscalls.master, > > not the name with a COMPAT* prefix which is the actual function name. > > > > Found while making a change to use the default capabilities.conf. Is there any automated way to detect this in the future? Can we add some test that detect non-existent syscalls or the like? -- Eitan Adler