From owner-freebsd-current@FreeBSD.ORG  Fri Jul 16 01:07:18 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 729F116A4CF; Fri, 16 Jul 2004 01:07:18 +0000 (GMT)
Received: from robbins.dropbear.id.au (137.c.002.mel.iprimus.net.au
	[203.134.135.137])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B6FFF43D4C; Fri, 16 Jul 2004 01:07:16 +0000 (GMT)
	(envelope-from tim@robbins.dropbear.id.au)
Received: by robbins.dropbear.id.au (Postfix, from userid 1000)
	id A7BCC41FD; Fri, 16 Jul 2004 11:07:07 +1000 (EST)
Date: Fri, 16 Jul 2004 11:07:07 +1000
From: Tim Robbins <tjr@freebsd.org>
To: Colin Percival <colin.percival@wadham.ox.ac.uk>
Message-ID: <20040716010707.GA22394@cat.robbins.dropbear.id.au>
References: <200407151424.i6FEOdoq060881@fledge.watson.org>
	<20040715220447.GA32888@xor.obsecurity.org>
	<6.1.0.6.1.20040715151650.03fae510@popserver.sfu.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6.1.0.6.1.20040715151650.03fae510@popserver.sfu.ca>
User-Agent: Mutt/1.4.1i
cc: re@freebsd.org
cc: current@freebsd.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: 5.3-RELEASE TODO
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Jul 2004 01:07:18 -0000

On Thu, Jul 15, 2004 at 03:20:19PM -0700, Colin Percival wrote:
> At 15:04 15/07/2004, Kris Kennaway wrote:
> >* linprocfs 
> >[...]
> >       if (pvd->pvd_pid != NO_PID) {
> >                if ((proc = pfind(pvd->pvd_pid)) == NULL)
> >                        PFS_RETURN (ENOENT);
> >-->             vap->va_uid = proc->p_ucred->cr_ruid;
> >
> >rwatson has a patch that works around this particular null pointer
> >deref, but the underlying cause is not addressed.
> 
> This looks like the "embryonic processes are added to allproc and
> p_hash too soon" bug (cf. kern/68364).  Last I heard, tjr was going
> to fix this in the next few days.

I was going to, but it turns out that my original solution of not
putting "embryonic" processes on allproc would further break checkdirs() --
there are already a few kinds of races that can happen there, and I don't
want to add more.


Tim