Date: Fri, 16 Jul 2004 11:07:07 +1000 From: Tim Robbins <tjr@freebsd.org> To: Colin Percival <colin.percival@wadham.ox.ac.uk> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: 5.3-RELEASE TODO Message-ID: <20040716010707.GA22394@cat.robbins.dropbear.id.au> In-Reply-To: <6.1.0.6.1.20040715151650.03fae510@popserver.sfu.ca> References: <200407151424.i6FEOdoq060881@fledge.watson.org> <20040715220447.GA32888@xor.obsecurity.org> <6.1.0.6.1.20040715151650.03fae510@popserver.sfu.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 15, 2004 at 03:20:19PM -0700, Colin Percival wrote:
> At 15:04 15/07/2004, Kris Kennaway wrote:
> >* linprocfs
> >[...]
> > if (pvd->pvd_pid != NO_PID) {
> > if ((proc = pfind(pvd->pvd_pid)) == NULL)
> > PFS_RETURN (ENOENT);
> >--> vap->va_uid = proc->p_ucred->cr_ruid;
> >
> >rwatson has a patch that works around this particular null pointer
> >deref, but the underlying cause is not addressed.
>
> This looks like the "embryonic processes are added to allproc and
> p_hash too soon" bug (cf. kern/68364). Last I heard, tjr was going
> to fix this in the next few days.
I was going to, but it turns out that my original solution of not
putting "embryonic" processes on allproc would further break checkdirs() --
there are already a few kinds of races that can happen there, and I don't
want to add more.
Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040716010707.GA22394>