From owner-svn-ports-all@FreeBSD.ORG Fri Aug 9 16:54:16 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C2A32205 for ; Fri, 9 Aug 2013 16:54:16 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com [209.85.215.47]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 46C3923EA for ; Fri, 9 Aug 2013 16:54:15 +0000 (UTC) Received: by mail-la0-f47.google.com with SMTP id eo20so3170579lab.20 for ; Fri, 09 Aug 2013 09:54:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=VaiIYr8ickaLkTuBYRdgf6UqFKiUnDSny9+RB8m3/ow=; b=F1Ox0mfH4l4z6wQNNzB7QezSB0qlKN9EYh/wbd/DiqnJdLVzDM8MzON28duu7UKvE9 gFN7+qSTejzEAiJi+iELo9GdYcdeWLhoqmdJjpoULnGGe3hiStc2wYt3b/5yDaa8Fx3t aapJKhGbV3kKkIiSid+vKNgpxBl6jCbRSC4XnIijB1bEV05Ix2QMiGhY77RFXUsqNunY 1lkSQg+oEjuE2zagEzNWka4mCjVY54MKqxWfp1mxTMTMhcBRZBe9eOjFrYiXGJP5OMsj XpnCE+Vl+fJW/YZOAmatTLVEh+5HHhaN+UOUQ04/xLehUgYE0C3JD1h7jg5ZOW1qobQ9 ux+g== X-Gm-Message-State: ALoCoQk2XFU4TQFDI424AQG9plzwOixhOZMZ6YdaKaOPT1lXKrrr9tZMg4ToJZPKviHxPSmo2ndb X-Received: by 10.152.116.7 with SMTP id js7mr6345931lab.11.1376065857532; Fri, 09 Aug 2013 09:30:57 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.27.161 with HTTP; Fri, 9 Aug 2013 09:30:37 -0700 (PDT) In-Reply-To: <5205054C.6060309@passap.ru> References: <201308091418.r79EITQv067141@svn.freebsd.org> <5205054C.6060309@passap.ru> From: Sunpoet Po-Chuan Hsieh Date: Sat, 10 Aug 2013 00:30:37 +0800 X-Google-Sender-Auth: 3HY8aPq1-0mN5ZepfgZI3O3xRnw Message-ID: Subject: Re: svn commit: r324438 - head/graphics/dcraw To: Boris Samorodov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Aug 2013 16:54:16 -0000 On Fri, Aug 9, 2013 at 11:05 PM, Boris Samorodov wrote: > 09.08.2013 18:18, Sunpoet Po-Chuan Hsieh =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > Author: sunpoet > > Date: Fri Aug 9 14:18:29 2013 > > New Revision: 324438 > > URL: http://svnweb.freebsd.org/changeset/ports/324438 > > > > Log: > > - Update to 9.19 > > - Cleanup Makefile header > > - Update maintainer section > > Seems to be a typo: maintainer->maketar. However this change: > [...] > > - ${INSTALL} -m 644 > ${MS_WRKSRC}/${PORTNAME}-${MS_VERSION}.tar.xz ${DISTDIR}/; \ > > + sudo ${INSTALL} -m 644 > ${MS_WRKSRC}/${PORTNAME}-${MS_VERSION}.tar.xz ${DISTDIR}/; \ > > ...is rather strange. Sudo is not a dependency at the port (sudo is not > at the base either). And the whole thing assumed to be launched with > root privileges anyway. > > -- > WBR, Boris Samorodov (bsam) > FreeBSD Committer, http://www.FreeBSD.org The Power To Serve > Hi, Maintainer section is from line 34 to line 56, therefore maketar target is for maintainer only. I meant to generate the tarball as normal user, not superuser. That's why I add "sudo" here. Regards, sunpoet