Date: Sat, 10 Aug 2013 00:30:37 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> To: Boris Samorodov <bsam@passap.ru> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r324438 - head/graphics/dcraw Message-ID: <CAMHz58QM0q8mbEZofB2X-SG2KZPRCjpDvHAMidPFNOOdCfHSpA@mail.gmail.com> In-Reply-To: <5205054C.6060309@passap.ru> References: <201308091418.r79EITQv067141@svn.freebsd.org> <5205054C.6060309@passap.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 9, 2013 at 11:05 PM, Boris Samorodov <bsam@passap.ru> wrote: > 09.08.2013 18:18, Sunpoet Po-Chuan Hsieh =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > Author: sunpoet > > Date: Fri Aug 9 14:18:29 2013 > > New Revision: 324438 > > URL: http://svnweb.freebsd.org/changeset/ports/324438 > > > > Log: > > - Update to 9.19 > > - Cleanup Makefile header > > - Update maintainer section > > Seems to be a typo: maintainer->maketar. However this change: > [...] > > - ${INSTALL} -m 644 > ${MS_WRKSRC}/${PORTNAME}-${MS_VERSION}.tar.xz ${DISTDIR}/; \ > > + sudo ${INSTALL} -m 644 > ${MS_WRKSRC}/${PORTNAME}-${MS_VERSION}.tar.xz ${DISTDIR}/; \ > > ...is rather strange. Sudo is not a dependency at the port (sudo is not > at the base either). And the whole thing assumed to be launched with > root privileges anyway. > > -- > WBR, Boris Samorodov (bsam) > FreeBSD Committer, http://www.FreeBSD.org The Power To Serve > Hi, Maintainer section is from line 34 to line 56, therefore maketar target is for maintainer only. I meant to generate the tarball as normal user, not superuser. That's why I add "sudo" here. Regards, sunpoet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58QM0q8mbEZofB2X-SG2KZPRCjpDvHAMidPFNOOdCfHSpA>