From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Oct 1 08:10:31 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5932916A4BF for ; Wed, 1 Oct 2003 08:10:31 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3707F43FEA for ; Wed, 1 Oct 2003 08:10:28 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h91FASFY035481 for ; Wed, 1 Oct 2003 08:10:28 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h91FARwZ035480; Wed, 1 Oct 2003 08:10:27 -0700 (PDT) (envelope-from gnats) Resent-Date: Wed, 1 Oct 2003 08:10:27 -0700 (PDT) Resent-Message-Id: <200310011510.h91FARwZ035480@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rui Lopes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3C5B16A4BF for ; Wed, 1 Oct 2003 08:09:03 -0700 (PDT) Received: from ns.webtt.biz (ns.webtt.biz [64.239.29.225]) by mx1.FreeBSD.org (Postfix) with SMTP id 2DAA243FBF for ; Wed, 1 Oct 2003 08:09:03 -0700 (PDT) (envelope-from root@ns.webtt.biz) Received: (qmail 55992 invoked by uid 0); 1 Oct 2003 15:11:09 -0000 Message-Id: <20031001151109.55991.qmail@ns.webtt.biz> Date: 1 Oct 2003 15:11:09 -0000 From: Rui Lopes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/57458: [PATCH] to fix editors/scite link error X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Rui Lopes List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2003 15:10:31 -0000 >Number: 57458 >Category: ports >Synopsis: [PATCH] to fix editors/scite link error >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Oct 01 08:10:27 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Rui Lopes >Release: FreeBSD 5.1-RELEASE-p5 i386 >Organization: >Environment: System: FreeBSD disty 5.1-RELEASE-p5 FreeBSD 5.1-RELEASE-p5 #2: Mon Sep 22 12:24:38 WEST 2003 root@disty:/usr/obj/usr/src/sys/DEBUGGER i386 >Description: The port does not link. It gives a lot of linking errors like these: cc `pkg-config --libs gtk+ gthread` -lscintilla -lscintilla_lexers -DGTK SciTEGTK.o SciTEBase.o SciTEBuffers.o SciTEIO.o Exporters.o DirectorExtension.o SciTEProps.o Utf8_16.o -o ../bin/SciTE SciTEGTK.o: In function `SciTEGTK::AddMBButton(_GtkWidget*, char const*, int, _GtkAccelGroup*, bool)': SciTEGTK.o(.text+0xa59): undefined reference to `operator delete[](void*)' SciTEGTK.o(.text+0xa66): undefined reference to `operator delete[](void*)' SciTEGTK.o(.text+0xa9a): undefined reference to `operator delete[](void*)' I also added a WITH_GNOME knob, with this set the port installs a launcher under gnome "Programming" menu. >How-To-Repeat: Just try to build the port. >Fix: The fix is to use the C++ compiler. NOTE: Probably it would be more correct to generate pkg-plist at runtime. --- scite.patch begins here --- diff -u scite.orig/Makefile scite/Makefile --- scite.orig/Makefile Wed Oct 1 15:30:04 2003 +++ scite/Makefile Wed Oct 1 15:32:48 2003 @@ -24,20 +24,37 @@ USE_X_PREFIX= yes USE_GMAKE= yes MAKEFILE= makefile +PLIST_SUB= GNOME_COMMENT=${GNOME_COMMENT} -.if defined(WITH_GTK2) +.if defined(WITH_GNOME) +USE_GNOME= gtk20 gnomeprefix +PKGNAMESUFFIX= -gnome +GNOME_COMMENT= '' +.elif defined(WITH_GTK2) USE_GNOME= gtk20 PKGNAMESUFFIX= -gtk2 .else USE_GNOME= gtk12 MAKE_ARGS= GTK1=yes .endif +GNOME_COMMENT?= '@comment ' + +post-patch: + @${REINPLACE_CMD} -e 's,$$(CC),$$(CXX),g' ${WRKSRC}/makefile +.if defined(WITH_GNOME) + @${TR} -d "\r" < ${WRKSRC}/SciTE.desktop > ${WRKDIR}/SciTE.desktop + @${ECHO_CMD} 'Categories=Application;Development;' >> ${WRKDIR}/SciTE.desktop +.endif do-install: ${INSTALL_PROGRAM} ${WRKSRC}/../bin/SciTE ${PREFIX}/bin ${INSTALL_MAN} ${WRKSRC}/../doc/scite.1 ${MANPREFIX}/man/man1 @${MKDIR} ${DATADIR} ${INSTALL_DATA} ${WRKSRC}/../src/*.properties ${DATADIR} +.if defined(WITH_GNOME) + ${INSTALL_DATA} ${WRKDIR}/SciTE.desktop ${PREFIX}/share/gnome/applications + ${INSTALL_DATA} ${WRKSRC}/Sci48M.png ${PREFIX}/share/gnome/pixmaps +.endif .if !defined(NOPORTDOCS) @${MKDIR} ${DOCSDIR} ${INSTALL_DATA} ${WRKSRC}/../doc/*.html ${DOCSDIR} Common subdirectories: scite.orig/files and scite/files diff -u scite.orig/pkg-plist scite/pkg-plist --- scite.orig/pkg-plist Wed Oct 1 15:30:04 2003 +++ scite/pkg-plist Wed Oct 1 15:27:49 2003 @@ -1,4 +1,6 @@ bin/SciTE +%%GNOME_COMMENT%%share/gnome/applications/SciTE.desktop +%%GNOME_COMMENT%%share/gnome/pixmaps/Sci48M.png %%PORTDOCS%%%%DOCSDIR%%/PrintHi.png %%PORTDOCS%%%%DOCSDIR%%/SciBreak2.jpg %%PORTDOCS%%%%DOCSDIR%%/SciTE.html --- scite.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: