From owner-cvs-all@FreeBSD.ORG  Thu Aug  3 17:34:13 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EC95F16A4DD;
	Thu,  3 Aug 2006 17:34:13 +0000 (UTC)
	(envelope-from phk@phk.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 76FF943D45;
	Thu,  3 Aug 2006 17:34:13 +0000 (GMT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id B3275170C5;
	Thu,  3 Aug 2006 17:34:11 +0000 (UTC)
To: "Simon L. Nielsen" <simon@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Thu, 03 Aug 2006 14:05:16 +0200."
	<20060803120515.GA1223@zaphod.nitro.dk> 
Date: Thu, 03 Aug 2006 17:34:10 +0000
Message-ID: <49150.1154626450@critter.freebsd.dk>
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/tools/tools/nanobsd nanobsd.sh 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2006 17:34:14 -0000

In message <20060803120515.GA1223@zaphod.nitro.dk>, "Simon L. Nielsen" writes:
>On 2006.07.13 14:06:10 +0000, Poul-Henning Kamp wrote:
>> phk         2006-07-13 14:06:10 UTC
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     tools/tools/nanobsd  nanobsd.sh 
>>   Log:
>>   Create the diskless magic files in /etc during the install_etc() step
>>   instead of setup_nanobsd(), because this gives customize tasks a chance
>>   to fiddle the details.
>
>This makes it a bit harder to (ab)use nanobsd.sh as a framework to
>build more normal FreeBSD images where a normal /etc is used.
>Previously I simply replaced setup_nanobsd in my customize script and
>I got a pretty standard FreeBSD install out in the end.
>
>Would you mind if I split the "diskless" magic out into
>setup_nanobsd_etc() (the parts code you moved in this commit) and then
>run it right after install_etc()?  It shouldn't make a difference for
>normal NanoBSD use, but then I can simply override setup_nanobsd_etc()
>in my cutomize script and avoid larger patches against nanobsd.sh.

That's ok with me.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.