From owner-svn-ports-all@FreeBSD.ORG Mon Feb 10 14:30:16 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DDFA4357; Mon, 10 Feb 2014 14:30:15 +0000 (UTC) Received: from mail-we0-x231.google.com (mail-we0-x231.google.com [IPv6:2a00:1450:400c:c03::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A8C7A127D; Mon, 10 Feb 2014 14:30:14 +0000 (UTC) Received: by mail-we0-f177.google.com with SMTP id t61so4318955wes.36 for ; Mon, 10 Feb 2014 06:30:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=TTaJ4MVoUkOqRPgrj3iSm+gikUhdrZxI93AeYlivWHs=; b=YZuvNiTT8nmzWPHc7gi/nZucxq36v7gGD1TT5qCC4+zz9BGMCjcFDTZcRvnLvPQPmI N2pVvzU7H821gPyX9AGi/4IPCf7T1bKOOxM5XKYcRbTh8ii7dXuOByZrKredASESRdnI t3AS+nA8q+mgKy0P+ZyoLADxzlXLhfUch2SKkdka3T1xvo/X9KMRDaNNG68x4J7LTXwp PMatlMNqF/qI5MooAuiAod2sL8UwgNulQvPBJGEGrxw//lIQ82YTn2sPr0FcrMQEJ31v w9oIjaaEYQuOKLKhri8hQkQwcfChDeX8dZmWTNNhGILQYS5Yuzq+M0dosurURm9sn690 xOAA== X-Received: by 10.194.142.142 with SMTP id rw14mr43573wjb.87.1392042612886; Mon, 10 Feb 2014 06:30:12 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id y18sm36953225wie.11.2014.02.10.06.30.09 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 10 Feb 2014 06:30:10 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 10 Feb 2014 15:30:07 +0100 From: Baptiste Daroussin To: Adam Weinberger Subject: Re: svn commit: r343559 - head/net-p2p/litecoin Message-ID: <20140210143007.GD80056@ithaqua.etoilebsd.net> References: <201402092329.s19NTHiq089517@svn.freebsd.org> <20140210011718.GA79272@mouf.net> <20140210075232.GU80056@ithaqua.etoilebsd.net> <20140210101243.GX80056@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4JxvUTD846AMAZAS" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@FreeBSD.org, Steve Wills , svn-ports-all@FreeBSD.org, John Marino , David Chisnall , ports-committers@FreeBSD.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2014 14:30:16 -0000 --4JxvUTD846AMAZAS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2014 at 09:10:06AM -0500, Adam Weinberger wrote: > On 10 Feb 2014, at 5:12, Baptiste Daroussin wrote: >=20 > > On Mon, Feb 10, 2014 at 09:47:17AM +0000, David Chisnall wrote: > >> On 10 Feb 2014, at 07:52, Baptiste Daroussin =20 > >> wrote: > >> > >>> I do not think that requires an approval, as for FreeBSD this change= =20 > >>> is no-op, > >>> It is also no intrusive and just "fixes" building of that port for=20 > >>> Dragonfly. > >> > >> Relying on OPSYS and OSVERSION is pretty horrible and doesn't scale. = =20 > >> Already we have problems with convoluted OSVERSION expressions that=20 > >> are hard to understand and really mean 'fix for PR12345 has been=20 > >> merged to the relevant branch'. It would be far better to centralise= =20 > >> these into a single file for each platform, listing features /=20 > >> bugfixes / needed work-arounds and start removing explicit OSVERSION= =20 > >> checks from any other Makefiles. If supporting Dragonfly is one of=20 > >> our objectives, then I'd strongly encourage the people who are=20 > >> working on it to engage in this kind of cleanup, rather than piling=20 > >> more hacks into the tree. > >> > >> David > >> > > > > If one has a nice idea to centralize those informations I'm all about= =20 > > it, by > > nice idea I mean format and implementation. > > > > May that be OPSYS and/or OSVERSION both requires loading too many=20 > > times bsd.*.mk > > which is not good, looking forward for propositions. > > > > regards, > > Bapt >=20 > pkgconf. It's ISC-licenced, has no external dependencies, and would be a= =20 > great way to store information about the system itself. Instead of using= =20 > magic to guess which compiler to use, a compiler.pc could tell you. The= =20 > mayhem that ensued when the threading library changed years ago, a=20 > thread.pc would have made it a piece of cake. You could store=20 > capabilities in .pc files and have a single reliable way to retrieve it. >=20 Given I'm upstream on pkgconf, I know a bit about it, but I still do not se= e how pkgconf can help us here :) regards, Bapt --4JxvUTD846AMAZAS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlL44m8ACgkQ8kTtMUmk6Ex5fgCeN9SFEUiY0ySKGRnCpnZvMDrU GQIAn3v+9DFFWAjioxJMk8TNTX7suyz5 =jwpg -----END PGP SIGNATURE----- --4JxvUTD846AMAZAS--