From owner-cvs-all@FreeBSD.ORG Sun Sep 17 01:13:10 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1923C16A40F; Sun, 17 Sep 2006 01:13:10 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CC6843D46; Sun, 17 Sep 2006 01:13:09 +0000 (GMT) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id k8H1D73t082747; Sat, 16 Sep 2006 18:13:07 -0700 (PDT) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id k8H1D67I082744; Sat, 16 Sep 2006 18:13:07 -0700 (PDT) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Sat, 16 Sep 2006 18:13:06 -0700 (PDT) From: mjacob@freebsd.org X-X-Sender: mjacob@ns1.feral.com To: Poul-Henning Kamp In-Reply-To: <71137.1158443604@critter.freebsd.dk> Message-ID: <20060916181136.S82705@ns1.feral.com> References: <71137.1158443604@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Matt Jacob , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Sep 2006 01:13:10 -0000 On Sat, 16 Sep 2006, Poul-Henning Kamp wrote: > In message <200609162121.k8GLL7rt005933@repoman.freebsd.org>, Matt Jacob writes > : >> mjacob 2006-09-16 21:21:07 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/cam/scsi scsi_da.c >> Log: >> Don't allow attachment of disks that could cause GEOM to panic. > > The correct commit message would have been: > > Don't allow attachment of disks which we couldn't possibly do I/O from. > > The problem is that there is a fixed upper limit for the I/O transfer > sizes we support (this should be fixed) and if the sectorsize is > larger, we're hosed. Au contraire mon frere.... You can attach to the device and *then* set it's block size to something reasonable via mode select. Si