From owner-cvs-all@FreeBSD.ORG Sat Aug 6 01:50:08 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAD1C16A41F; Sat, 6 Aug 2005 01:50:08 +0000 (GMT) (envelope-from ssouhlal@FreeBSD.org) Received: from efnet-math.org (efnet-math.org [69.60.109.125]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3A0843D48; Sat, 6 Aug 2005 01:50:07 +0000 (GMT) (envelope-from ssouhlal@FreeBSD.org) Received: from [151.28.123.29] (ppp-29-123.28-151.libero.it [151.28.123.29]) (authenticated bits=0) by efnet-math.org (8.13.1/8.13.1) with ESMTP id j761o2SY006497 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO); Fri, 5 Aug 2005 21:50:04 -0400 In-Reply-To: <200508060142.j761g4WL038761@repoman.freebsd.org> References: <200508060142.j761g4WL038761@repoman.freebsd.org> Mime-Version: 1.0 (Apple Message framework v733) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <518A155E-C0F3-4582-A122-724A8CA76FBC@FreeBSD.org> Content-Transfer-Encoding: 7bit From: Suleiman Souhlal Date: Sat, 6 Aug 2005 03:49:53 +0200 To: Suleiman Souhlal X-Mailer: Apple Mail (2.733) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c src/sys/sys mount.h vnode.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Aug 2005 01:50:08 -0000 On Aug 6, 2005, at 3:42 AM, Suleiman Souhlal wrote: > ssouhlal 2005-08-06 01:42:04 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_subr.c > sys/sys mount.h vnode.h > Log: > Holding a vnode doesn't prevent v_mount from disappearing (when the > vnode is inactivated), possibly leading to a NULL dereference when > checking if the mount wants knotes to be activated in the VOP hooks. > So, we add a new vnode flag VV_NOKNOTE that is only set in > getnewvnode(), > if necessary, and check it when activating knotes. > Since the flags are not erased when a vnode is being held, we can > safely > read them. > > Reviewed by: kris@ Err, this should be Reported by: kris@ -- Suleiman Souhlal | ssouhlal@vt.edu The FreeBSD Project | ssouhlal@FreeBSD.org