From owner-svn-ports-all@freebsd.org  Wed Dec  6 17:44:08 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33DDCE86F1F;
 Wed,  6 Dec 2017 17:44:08 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 15A9E7B5F8;
 Wed,  6 Dec 2017 17:44:08 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 51BC1E900; Wed,  6 Dec 2017 17:44:07 +0000 (UTC)
Date: Wed, 6 Dec 2017 17:44:07 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kurt Jaeger <pi@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r455665 - head/audio/zynaddsubfx
Message-ID: <20171206174407.GA82869@FreeBSD.org>
References: <201712061730.vB6HU6hn021797@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201712061730.vB6HU6hn021797@repo.freebsd.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2017 17:44:08 -0000

On Wed, Dec 06, 2017 at 05:30:06PM +0000, Kurt Jaeger wrote:
> New Revision: 455665
> URL: https://svnweb.freebsd.org/changeset/ports/455665
> 
> Log:
>   audio/zynaddsubfx: fix build on cur, 10.x by force llvm40

Commit message does not explain what was the original problem, so it's
hard to judge whether attempted solution is correct or not.

> @@ -41,8 +41,8 @@ GUI_LIB_DEPENDS=		libfltk.so:x11-toolkits/fltk \
>  				libfontconfig.so:x11-fonts/fontconfig
>  GUI_ON=				-DGuiModule:STRING=fltk
>  GUI_CMAKE_OFF=			-DGuiModule:STRING=OFF
> -GUI_USE+=			XORG=x11,xext,xfixes,xcursor,ice,sm,xpm,xinerama,xft
> -GUI_USE+=			GL=glu
> +GUI_USE+=			XORG=x11,xext,xfixes,xcursor,xrender,ice,sm,xpm,xinerama,xft
> +GUI_USE+=			GL=gl,glu

This change was not explained in the commit log.

> +.include <bsd.port.options.mk>

What is this .include <bsd.port.options.mk> needed for?

> +# Build fix for ZynAddSubFx
> +BUILD_DEPENDS+=	clang40:devel/llvm40
> +CC=		clang40
> +CXX=		clang++40

./danfe