From nobody Sat Sep 7 01:48:00 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X0wwK0vMkz5WSLV; Sat, 07 Sep 2024 01:48:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X0wwJ4wRPz4jxJ; Sat, 7 Sep 2024 01:48:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725673680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9tWVrCCdej88Jl2I1AsZG1HQnNlSmQzsE/8BuuZTmPI=; b=Iv7q44ka+In22s2qHv4OEZqOsiugTETcc31F3FQkQ3Bos+z0EGwkq2dfMvIFXdLLhgjFWu 5gTD+JueTRBIVywiCp1BYqQgeSUnzdsFUcuibOvwawJ5hzHCR4UYsadRjIGd8WMqukA5Be 3Gz+8W3SVJLbCwxonfMxcHMg9hXUecjy4qlFfD/NLBcEpySGwaYJXD6fUT2cAPJLvQcFVw x370G5+UG4mF5N/1AD21B9zeqix+ydcOuTnsuCYRgJC1ZBVxF4vh2JGyhxcBLsm6cKxHcG eSEbgM4HGnCzfvin8E01SqG2DZsrw0uBvIyzZr++Fc9kzLQV9tNfJk0tOi6+Hg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725673680; a=rsa-sha256; cv=none; b=ug95HGdD6E90WeRZ9oVL8lYHI6CnMKk7fBhmtCq1W2kjNvzIJ3a53ex+zBKtMBcQQsnxB5 Vrn/+rYCUjSxINLXpmiT5mSkuQQZAlKUHITn1eGR+FWgq+U8p+H2oKNYueXGejPZLLR501 APGFEBUIDsJwUtx7NXE7EOA0laJTGw6zNZrj1MHRg01e5CuzmmshAjvZwLaJSnuHBiop88 EEfWIFfIXWsqm3g1jLascfqjOGHXg0zlR/hH6F0U6i43n2Suoj7yCWz7I9AIJHDgrIJ6hb nznBsabN8Ic2/jBWSxIYx/z0VM4nYV0+G61zyJKTACovmog3vjXtHXzUgkIaiw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725673680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9tWVrCCdej88Jl2I1AsZG1HQnNlSmQzsE/8BuuZTmPI=; b=UEDj7SQ7YL64VmrOgf7TdXjFFNUQ26cWS9XdTmJEIs/vTqg+pnScOKCTDS8iGhYYG1Z+Yi sX/srEWli31J40wrnORgnBeJ9h4XeTdp3JtdXVclyCqHNcCC5bAYo2A7Y94uKHC8cJj/Qj 4FmZKcneqafX+8VDHMRLV5GCcKDD03bHlNRVMIuAT6QpPOvy+KCZN3tIFkKt+48q8ydsvt rsCVUv4s8ey29oZng6N9BawcC+AeOEs/yjGRmRjyABkfLx9mZ2OnF29J6vZ8qGEWnHjNvN SdWx2C2YKbzeVDSA5PhYd5TiAhjELTCnDptY6phOWEHJd2w/ACk/8rJkhQn2bQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X0wwJ4VcdzGM8; Sat, 7 Sep 2024 01:48:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4871m0Ee041758; Sat, 7 Sep 2024 01:48:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4871m0xb041755; Sat, 7 Sep 2024 01:48:00 GMT (envelope-from git) Date: Sat, 7 Sep 2024 01:48:00 GMT Message-Id: <202409070148.4871m0xb041755@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jessica Clarke Subject: git: 6368aa66f8a7 - stable/14 - bsdinstall: Drop Error from title in netconfig no interfaces dialog List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6368aa66f8a7c5f1ac322575e4ce4ee4d196b4d8 Auto-Submitted: auto-generated The branch stable/14 has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=6368aa66f8a7c5f1ac322575e4ce4ee4d196b4d8 commit 6368aa66f8a7c5f1ac322575e4ce4ee4d196b4d8 Author: Jessica Clarke AuthorDate: 2024-02-03 01:52:53 +0000 Commit: Jessica Clarke CommitDate: 2024-09-07 00:00:51 +0000 bsdinstall: Drop Error from title in netconfig no interfaces dialog This isn't inherently an error. It is if you're attempting to download dist tarballs or later install packages, but a FreeBSD system with no NIC is a reasonable setup to have, especially in a throwaway VM setting, so we shouldn't say it is one. Leaving the exit code as 1 is still fine, since auto will ignore it, and avoids breaking other uses. MFC after: 1 week (cherry picked from commit 7414d14bd51d8378057bbe952c2715b9f32d1d3e) --- usr.sbin/bsdinstall/scripts/netconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bsdinstall/scripts/netconfig b/usr.sbin/bsdinstall/scripts/netconfig index 300dcc6f5e5e..19644898a66a 100755 --- a/usr.sbin/bsdinstall/scripts/netconfig +++ b/usr.sbin/bsdinstall/scripts/netconfig @@ -67,7 +67,7 @@ done if [ -z "$INTERFACES" ]; then bsddialog --backtitle "$OSNAME Installer" \ - --title 'Network Configuration Error' \ + --title 'Network Configuration' \ --msgbox 'No network interfaces present to configure.' 0 0 exit 1 fi