From owner-svn-src-all@freebsd.org Fri Sep 1 16:50:37 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C939E1A09B for ; Fri, 1 Sep 2017 16:50:37 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E6827EC2D; Fri, 1 Sep 2017 16:50:37 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 53C397A82; Fri, 1 Sep 2017 16:50:36 +0000 (UTC) Date: Fri, 1 Sep 2017 16:50:36 +0000 From: Alexey Dokuchaev To: Josh Paetzel Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf Message-ID: <20170901165036.GA32922@FreeBSD.org> References: <201709011554.v81FssRG083114@repo.freebsd.org> <1504283036.3890655.1092421712.7A5915D1@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504283036.3890655.1092421712.7A5915D1@webmail.messagingengine.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 16:50:37 -0000 On Fri, Sep 01, 2017 at 11:23:56AM -0500, Josh Paetzel wrote: > Yeah, the commit message is horrible. I apologize. I'm afraid this is not enough, esp. considering that this issue (utterly bad commit messages) was recently brought up on developers@ once again. Please revert and recommit with proper, elaborate, useful commit log. > The phabricator is a little better but you have to read and parse the > whole thing. > > Then end result of this change is you can kldload ipsec AND tcpmd5, > however ipsec support won't be in GENERIC. Perhaps it should also explain why IPSEC_SUPPORT option is needed, as well (e.g. if it does not cost anything, why not just optimize it away; if it does imply something more, it should be explained and reflected properly in the log). ./danfe