Date: Sat, 12 Apr 2008 15:59:45 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Sam Leffler <sam@freebsd.org> Cc: Kirk McKusick <mckusick@mckusick.com>, arch@freebsd.org Subject: Re: VOP_LEASE Message-ID: <20080412225945.GY95731@elvis.mu.org> In-Reply-To: <48011074.9060906@freebsd.org> References: <200804121703.m3CH3StJ081660@chez.mckusick.com> <41ED3941-E5E6-45F0-B880-C1B2861FDE32@rabson.org> <48011074.9060906@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Sam Leffler <sam@freebsd.org> [080412 12:41] wrote: > Doug Rabson wrote: > > > >On 12 Apr 2008, at 18:03, Kirk McKusick wrote: > > > >>>Date: Sat, 12 Apr 2008 02:13:15 -1000 (HST) > >>>From: Jeff Roberson <jroberson@jroberson.net> > >>>To: arch@freebsd.org > >>>Subject: VOP_LEASE > >>> > >>>As far as I can tell this has never been used. Unless someone can > >>>show me > >>>otherwise I'm going to go ahead and remove it. > >>> > >>>Thanks, > >>>Jeff > >> > >>VOP_LEASE is used by NQNFS and NFSv4. It notifies them when a file > >>is modified locally so that they know to update any outstanding > >>leases (e.g., evict any write lease for the file and do callbacks > >>for any read leases for the file). Deleting VOP_LEASE would break > >>NFS big time. > > > >I think our NQNFS support might have been removed some time ago - I > >can't see any calls to VOP_LEASE in the code right now. Something like > >VOP_LEASE would certainly be useful for a hypothetical future NFSv4 > >server. I believe that samba could use it too for its oplocks feature > >which appears to be similar to NQNFS's leases and NFSv4's delegations. > > > > Note NQNFS is long dead (netbsd removed it also not too long > ago--together with VOP_LEASE). Jeff doesn't say why he wants to remove > it but it might be best removed only to return when there's a real > consumer of the api. We have people on the verge of implementing NFSv4, in fact we have a half-done client right now. I don't think it makes sense to remove it as I have stated before. -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080412225945.GY95731>