From nobody Sat Aug 23 17:10:11 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c8Npt6Q5Kz669NC; Sat, 23 Aug 2025 17:10:14 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c8Npt40K6z3V7m; Sat, 23 Aug 2025 17:10:14 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTPS id pnaNumwRN9JM2prkrukgqL; Sat, 23 Aug 2025 17:10:13 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id prkquyqPJWX70prkruo6ML; Sat, 23 Aug 2025 17:10:13 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=d71WygjE c=1 sm=1 tr=0 ts=68a9f5f5 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=2OwXVqhp2XgA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=T_YFPyFoAAAA:8 a=CjxXgO3LAAAA:8 a=YxBL1-UpAAAA:8 a=v42OIU9iIEuCMG5iv_8A:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=fKaBkT6cBtmegwcwHIDe:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy.cwsent.com [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id C6DA5C60; Sat, 23 Aug 2025 10:10:11 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id BCFFF189; Sat, 23 Aug 2025 10:10:11 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: ShengYi Hung cc: Gordon Bergling , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1685192ea1fa - main - hkbd: remove erorr detection in KDSKBSTATE ioctl In-reply-to: References: <202508230450.57N4oxwG023161@gitrepo.freebsd.org> Comments: In-reply-to ShengYi Hung message dated "Sat, 23 Aug 2025 15:38:58 +0800." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 23 Aug 2025 10:10:11 -0700 Message-Id: <20250823171011.BCFFF189@slippy.cwsent.com> X-CMAE-Envelope: MS4xfF/vvkX7UB73UW4ugdA+8B09WXwHUKErHF0CAnT4nYPqth1a6Etk833uV/Nfw0DWHr/shjh0zN5ACc+g+vIXah5ikvIt+hLE4VrJqqDD44jyFk08OcHu IHnIuCehxoAd5QmMIQDmt23uMca61+FGotbHDF/bLt9/wvBnxSLhdUNh8powh+GeSPdY7qcIGSIDchJdJslPrrIthsn8QFvyMLF5AKnMqebQsmfWpoqe5JT+ t2jw08Lz7kRJPo4jYwIxEJ4tzoPG4jX3VezvFF+R1kZBAveQH7ismcUw/R1glucAize8+bILgnhgDDaEjFtvpjwHnqkFPHVl7OBxz4qQatGLKPQMNLA2CR+p 07R37M38 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c8Npt40K6z3V7m In message , ShengYi Hung writes: > > Hello, thanks for the reminder. I compile the standalone module to test so > didn't discover that. Fix it right now. > Gordon Bergling writes: > > > > Hi ShengYi, > > > > On Sat, Aug 23, 2025 at 04:50:59AM +0000, ShengYi Hung wrote: > >> The branch main has been updated by aokblast: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=1685192ea1faac28f2d4feede53e7 > 0b6a380500f > >> > >> commit 1685192ea1faac28f2d4feede53e70b6a380500f > >> Author: ShengYi Hung > >> AuthorDate: 2025-08-21 17:59:15 +0000 > >> Commit: ShengYi Hung > >> CommitDate: 2025-08-23 04:50:09 +0000 > >> > >> hkbd: remove erorr detection in KDSKBSTATE ioctl > >> > >> The KDSKBSTATE ioctl brings the LED up. However, some keyboards (like > qemu > >> keyboard) may not have LED or failed to set the LED due to unexpected > reason. > >> Therefore, removing the error check as ukbd(4) does allow the keyboard > works > >> correctly with kbdcontrol(4). > >> > >> Also move hw.hid.hkbd.no_leds sysctl out of HID_BUG thus users can > >> disable setting LEDs > >> > >> PR: 288968 > >> Reviewed by: wulf > >> Tested by: trashcan@ellael.org, marklmi26-fbsd@yahoo.com, trkelle > rs@gmail.coom > >> Approved by: lwsu (mentor), markj (mentor) > >> MFC after 1 week > >> Sponsored by: The FreeBSD Foundation > >> Differential Revision: https://reviews.freebsd.org/D52101 > >> > >> mvalsmva > >> --- > > > > I am not sure how this is related, but since that commit, buildkernel of GE > NERIC is broken both > > on amd64 and aarch64. The following error is from an amd64 build, aarch64 i > s the same. > > > > ----------------------------- > > /storage/freebsd/src/current/sys/dev/hid/hkbd.c:1831:10: error: called ob > ject type 'char[5]' is not a function or function pointer > > 1831 | DPRINTF(("error %d", error)); > > | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ > > /storage/freebsd/src/current/sys/dev/hid/hid.h:212:34: note: expanded fro > m macro 'DPRINTF' > > 212 | #define DPRINTF(...) DPRINTFN(1, __VA_ARGS__) > > | ~~~~~~~~~~~~^~~~~~~~~~~~ > > /storage/freebsd/src/current/sys/dev/hid/hid.h:208:17: note: expanded fro > m macro 'DPRINTFN' > > 208 | printf("%s: " fmt, \ > > | ~~~~~~ ^ > > 1 error generated. > > --- hkbd.o --- > > *** [hkbd.o] Error code 1 > > ----------------------------- > > > > --Gordon > > -- > Best Regards. > ShengYi Hung. > My machines running X (laptops), - the right mouse key no longer works under X, I can no longer use X, - the caps-lock light will not display under X - on the text console works, X does not. The three commits related have bee reverted locally, functionality has returned. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0